fix(rpc): accept jwt's starting with 0x#1589
Merged
onbjerg merged 2 commits intoparadigmxyz:mainfrom Feb 28, 2023
Merged
Conversation
palango
force-pushed
the
hex-jwt
branch
2 times, most recently
from
e82863a to
8e7bfce
Compare
palango
changed the title
0x0x
mattsse
requested changes
Feb 28, 2023
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
please mention this behavior to the docs
lgtm otherwise.
Contributor
Author
Just the inline comments or is there some other place to mention this? |
Collaborator
|
simply add a note to the function doc that this strips leading 0x |
onbjerg
reviewed
Feb 28, 2023
onbjerg
approved these changes
Feb 28, 2023
mattsse
approved these changes
Feb 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1586