Skip to content

chore(deps): bump clap#1574

Merged
gakonst merged 1 commit intomainfrom
matt/bump-clap
Feb 28, 2023
Merged

chore(deps): bump clap#1574
gakonst merged 1 commit intomainfrom
matt/bump-clap

Conversation

@mattsse
Copy link
Collaborator

@mattsse mattsse commented Feb 27, 2023

new clap release

Closes #1572

@rkrasiuk seems like your fix missed some cases.

failed to allow this manually via clippy allow

@mattsse mattsse added the A-dependencies Pull requests or issues that are about dependencies label Feb 27, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2023

Codecov Report

Merging #1574 (5f15c78) into main (5e0fa44) will increase coverage by 0.04%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1574      +/-   ##
==========================================
+ Coverage   74.99%   75.04%   +0.04%     
==========================================
  Files         372      372              
  Lines       43610    43610              
==========================================
+ Hits        32706    32726      +20     
+ Misses      10904    10884      -20     
Flag Coverage Δ
integration-tests 21.45% <ø> (+0.02%) ⬆️
unit-tests 69.58% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
crates/net/downloaders/src/bodies/task.rs 95.45% <0.00%> (-1.14%) ⬇️
crates/stages/src/stages/bodies.rs 92.43% <0.00%> (-0.43%) ⬇️
crates/stages/src/stages/hashing_storage.rs 95.38% <0.00%> (-0.28%) ⬇️
crates/net/eth-wire/src/p2pstream.rs 79.41% <0.00%> (-0.18%) ⬇️
crates/net/downloaders/src/headers/task.rs 83.67% <0.00%> (ø)
crates/net/discv4/src/lib.rs 65.67% <0.00%> (+0.07%) ⬆️
crates/net/network/src/session/active.rs 85.18% <0.00%> (+0.44%) ⬆️
crates/net/network/src/session/mod.rs 77.94% <0.00%> (+1.35%) ⬆️
crates/net/network/src/listener.rs 83.72% <0.00%> (+2.32%) ⬆️
crates/net/discv4/src/proto.rs 92.78% <0.00%> (+3.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mattsse mattsse requested a review from rkrasiuk February 27, 2023 20:30
@gakonst gakonst merged commit 530a4a0 into main Feb 28, 2023
@gakonst gakonst deleted the matt/bump-clap branch February 28, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-dependencies Pull requests or issues that are about dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failing clippy check on latest nightly

3 participants