Conversation
gakonst
commented
Feb 26, 2023
Comment on lines
+32
to
+33
| /// An inspector that prints the opcode traces to the console. | ||
| pub custom_print_tracer: Option<CustomPrintTracer>, |
Member
Author
There was a problem hiding this comment.
We'll introduce other inspectors here. cc @joshieDo for snapshotting state touched
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1567 +/- ##
==========================================
- Coverage 75.15% 74.93% -0.22%
==========================================
Files 371 372 +1
Lines 43342 43510 +168
==========================================
+ Hits 32572 32605 +33
- Misses 10770 10905 +135
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
onbjerg
approved these changes
Feb 27, 2023
Collaborator
onbjerg
left a comment
onbjerg
left a comment
There was a problem hiding this comment.
LGTM as a starting point
onbjerg
added
C-enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We need better ways to inspect the internal state of various transactions when using the executor.
Solution
Introduces an
InspectorStacksimilar to Foundry's which allows hooking on a transaction hash or a block and run a bunch of inspectors for each transaction.In a follow-up PR, we should integrate this with the ExecutionStage, so that we can expose it e.g. for
reth stagedebugging.