Skip to content

feat: add eth state cache#1561

Merged
mattsse merged 3 commits intomainfrom
matt/add-eth-cache
Feb 28, 2023
Merged

feat: add eth state cache#1561
mattsse merged 3 commits intomainfrom
matt/add-eth-cache

Conversation

@mattsse
Copy link
Collaborator

@mattsse mattsse commented Feb 25, 2023

Closes #1532

WIP

Adds an async caching layer for eth related data.

See mod docs for details

Needs followup to integrate in EthApi

@onbjerg onbjerg added the C-enhancement New feature or request label Feb 27, 2023
@mattsse mattsse marked this pull request as ready for review February 27, 2023 17:07
@mattsse mattsse requested a review from gakonst as a code owner February 27, 2023 17:07
@codecov-commenter
Copy link

Codecov Report

Merging #1561 (573e9a2) into main (5e0fa44) will decrease coverage by 0.23%.
The diff coverage is 7.27%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1561      +/-   ##
==========================================
- Coverage   74.99%   74.76%   -0.23%     
==========================================
  Files         372      373       +1     
  Lines       43610    43762     +152     
==========================================
+ Hits        32706    32720      +14     
- Misses      10904    11042     +138     
Flag Coverage Δ
integration-tests 21.37% <0.00%> (-0.05%) ⬇️
unit-tests 69.34% <7.27%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
crates/interfaces/src/provider.rs 0.00% <ø> (ø)
crates/rpc/rpc/src/eth/cache.rs 0.00% <0.00%> (ø)
crates/storage/provider/src/providers/mod.rs 17.04% <0.00%> (-0.40%) ⬇️
crates/storage/provider/src/test_utils/mock.rs 36.09% <0.00%> (-1.86%) ⬇️
crates/storage/provider/src/test_utils/noop.rs 26.04% <0.00%> (-3.03%) ⬇️
crates/storage/provider/src/traits/evm_env.rs 0.00% <ø> (ø)
crates/executor/src/executor.rs 93.73% <100.00%> (+0.05%) ⬆️
crates/revm/revm-primitives/src/env.rs 50.74% <100.00%> (+0.37%) ⬆️
crates/net/downloaders/src/bodies/task.rs 95.45% <0.00%> (-1.14%) ⬇️
crates/net/eth-wire/src/p2pstream.rs 79.41% <0.00%> (-0.18%) ⬇️
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattsse mattsse added the A-rpc Related to the RPC implementation label Feb 28, 2023
@mattsse mattsse merged commit 7a01e1e into main Feb 28, 2023
@mattsse mattsse deleted the matt/add-eth-cache branch February 28, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-rpc Related to the RPC implementation C-enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add async caching service to Eth RPC api

3 participants