Skip to content

fix(rpc): return eth_call fee errors as invalid params#1559

Merged
mattsse merged 1 commit intomainfrom
matt/add-eth-call-errors-to-invalid-params
Feb 27, 2023
Merged

fix(rpc): return eth_call fee errors as invalid params#1559
mattsse merged 1 commit intomainfrom
matt/add-eth-call-errors-to-invalid-params

Conversation

@mattsse
Copy link
Collaborator

@mattsse mattsse commented Feb 25, 2023

return invalid params error code if eth_call request misconfigured

@mattsse mattsse requested a review from gakonst as a code owner February 25, 2023 14:38
@mattsse mattsse added the A-rpc Related to the RPC implementation label Feb 25, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2023

Codecov Report

Merging #1559 (7ce63b3) into main (41748e8) will increase coverage by 0.08%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1559      +/-   ##
==========================================
+ Coverage   75.10%   75.19%   +0.08%     
==========================================
  Files         371      371              
  Lines       43347    43347              
==========================================
+ Hits        32554    32593      +39     
+ Misses      10793    10754      -39     
Flag Coverage Δ
integration-tests 21.56% <0.00%> (+0.01%) ⬆️
unit-tests 69.72% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
crates/rpc/rpc/src/eth/error.rs 8.77% <100.00%> (ø)
crates/stages/src/stages/bodies.rs 92.43% <0.00%> (-0.43%) ⬇️
crates/net/discv4/src/lib.rs 65.67% <0.00%> (+0.07%) ⬆️
crates/net/network/src/manager.rs 52.49% <0.00%> (+0.18%) ⬆️
crates/net/eth-wire/src/ethstream.rs 83.97% <0.00%> (+0.23%) ⬆️
crates/transaction-pool/src/pool/txpool.rs 61.56% <0.00%> (+0.49%) ⬆️
crates/stages/src/stages/sender_recovery.rs 91.48% <0.00%> (+0.53%) ⬆️
crates/net/downloaders/src/bodies/task.rs 96.59% <0.00%> (+1.13%) ⬆️
crates/net/discv4/src/proto.rs 92.78% <0.00%> (+3.12%) ⬆️
crates/transaction-pool/src/test_utils/mock.rs 68.15% <0.00%> (+6.50%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse merged commit 5e0fa44 into main Feb 27, 2023
@mattsse mattsse deleted the matt/add-eth-call-errors-to-invalid-params branch February 27, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-rpc Related to the RPC implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants