Conversation
onbjerg
added
C-enhancement
Collaborator
Author
|
Hmm, actually, I think this might be a bug in the tool itself. Investigating Edit: Does not seem to be a bug. We store a lot of data that we do not need to - I could not find any rules that would warrant us keeping this data around |
It is now possible to go to new pages in `reth db list` using the left and right arrow keys, as well as skipping to a specific page using `G`.
onbjerg
force-pushed
the
onbjerg/db-list-paging
branch
from
342ae52 to
363e396
Compare
Collaborator
Author
|
@gakonst We figured out that it was leftover state from before the state clearing EIP |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds paging to
reth db list: left and right arrows go to prev/next page, and G lets you jump to a specific page (note: jumping far is super slow, so I would recommend not doing it)I used this to explore the database a bit; it seems a lot of accounts we have written to the database are completely empty:
I'm not sure if there is a specific reason for this (i.e. if we have to), but if not, we should definitely remove these accounts.