Skip to content

chore: fix all the obvious clippy warnings#1520

Merged
rkrasiuk merged 2 commits intoparadigmxyz:mainfrom
tomarST:main
Feb 26, 2023
Merged

chore: fix all the obvious clippy warnings#1520
rkrasiuk merged 2 commits intoparadigmxyz:mainfrom
tomarST:main

Conversation

@tomarST
Copy link
Contributor

@tomarST tomarST commented Feb 23, 2023

Partial fix for #1462

@rakita
Copy link
Collaborator

rakita commented Feb 23, 2023

ty for contributing! cargo +nightly fmt is needed

@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2023

Codecov Report

Merging #1520 (6612fa2) into main (0fc9f67) will decrease coverage by 0.45%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1520      +/-   ##
==========================================
- Coverage   76.00%   75.56%   -0.45%     
==========================================
  Files         358      368      +10     
  Lines       42660    43025     +365     
==========================================
+ Hits        32423    32510      +87     
- Misses      10237    10515     +278     
Flag Coverage Δ
integration-tests 21.70% <0.00%> (-0.17%) ⬇️
unit-tests 70.04% <100.00%> (-0.41%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
crates/stages/src/stages/index_account_history.rs 98.18% <100.00%> (-0.02%) ⬇️
crates/stages/src/stages/index_storage_history.rs 98.30% <100.00%> (-0.02%) ⬇️
crates/rpc/rpc/src/eth/error.rs 13.88% <0.00%> (-12.43%) ⬇️
bin/reth/src/args/rpc_server_args.rs 63.46% <0.00%> (-8.19%) ⬇️
crates/rpc/rpc/src/eth/api/mod.rs 69.13% <0.00%> (-5.54%) ⬇️
crates/storage/provider/src/test_utils/mock.rs 44.84% <0.00%> (-4.49%) ⬇️
crates/net/discv4/src/proto.rs 89.66% <0.00%> (-3.13%) ⬇️
crates/net/eth-wire/src/ethstream.rs 83.97% <0.00%> (-3.07%) ⬇️
crates/rpc/rpc-engine-api/src/engine_api.rs 92.37% <0.00%> (-1.44%) ⬇️
crates/net/network/src/session/mod.rs 76.59% <0.00%> (-1.36%) ⬇️
... and 45 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@onbjerg onbjerg changed the title fix all the obvious clippy warnings chore: fix all the obvious clippy warnings Feb 24, 2023
@onbjerg onbjerg added the C-debt A clean up/refactor of existing code label Feb 24, 2023
Copy link
Contributor

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomarST thanks! i've changed the PR description in order to unlink the PR from the issue since this doesn't fix all the warnings. moving forward, could you pls also avoid making PRs from the fork main branch? this makes it cumbersome to check out the PRs locally

@rkrasiuk
Copy link
Contributor

@tomarST are you planning to add smth here or can we move it from the draft status?

@rkrasiuk rkrasiuk marked this pull request as ready for review February 26, 2023 08:40
@rkrasiuk rkrasiuk merged commit 662fd87 into paradigmxyz:main Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-debt A clean up/refactor of existing code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants