Implement txpool interop support for optimism

[SozinM]

Closes #14552

• Introduced SupervisorClient for handling interactions with the supervisor.
• Updated OpTransactionValidator to include a supervisor client for cross-transaction validation.
• Enhanced error handling for invalid cross transactions in the transaction pool.
• Added dependencies for kona packages in Cargo.toml and Cargo.lock.

Removed #[expect(clippy::derivable_impls)] from args, because not it's not derivable

[emhane]

looking good so far

[SozinM]

Couple of questions @emhane

1. Are we okay introducing something like "first seen" for transaction in txpool? We'll need this if we want time have 1 day timeout window for sup validation.
2. I need to check that we have supervisor_url set if interop is activated. I was thinking doing it here but i can't find easy way to do this. Is there a better place to do this?
3. Do we want propagate InteropValidatorTxError to InvalidPoolTransactionError?

[SozinM]

Okay, now it's close to completion
Only things left:
Check that we have supervisor_http if interop is enabled
Decide if we change error type or not

[emhane]

tx pool builder in node builder is the place to check that supervisor url is set if interop is active, there you should have access to the chain spec in order to do this

[mattsse]

overall I think this should work,

left some suggestions/questions

[mattsse]

you can solve this via required_if clap argument

[SozinM]

interop is hardfork, so it's impossible to check on args itself, or am i wrong?

[SozinM]

@mattsse pushed changes
one this that confused me is error, could you clarify it a bit please?
also i forgot that the last step is to add first seen into txpool

[SozinM]

I assume i would add first_seen only into OpPooledTransaction, because i won't use it for eth
But i would need to also set it. Is there good centralized place when we build received transaction? Via both p2p and rpc

[emhane]

I assume i would add first_seen only into OpPooledTransaction, because i won't use it for eth But i would need to also set it. Is there good centralized place when we build received transaction? Via both p2p and rpc

imo we can do the first seen, expire validity after 24h, in a follow up pr. let's get the base running first. for that later pr, first seen will probably want to be variable, set in node builder, since tests unlikely want to extend over 24h for early debugging.

[mattsse]

getting closer, some more suggestions.

also, @emhane we need to solve the kona dependency requirement, can't introduce this here

[mattsse]

this should probably be the SafetyLevel type directly, we need a fromstr impl for that

[mattsse]

I believe this setup is problematic, because this doesn't account for when interop will be activated and only check the current local head block, which will always be false if a fresh node is started.

we need to track activation dynamically:

reth/crates/transaction-pool/src/validate/eth.rs

Lines 114 to 117 in 9cb7177

	fn on_new_head_block<B>(&self, new_tip_block: &SealedBlock<B>)
	where
	B: Block,
	{

similar to how fork activations are tracked here:

reth/crates/transaction-pool/src/validate/eth.rs

Lines 519 to 527 in 9cb7177

	fn on_new_head_block<T: BlockHeader>(&self, new_tip_block: &T) {
	// update all forks
	if self.chain_spec().is_cancun_active_at_timestamp(new_tip_block.timestamp()) {
	self.fork_tracker.cancun.store(true, std::sync::atomic::Ordering::Relaxed);
	}
	if self.chain_spec().is_shanghai_active_at_timestamp(new_tip_block.timestamp()) {
	self.fork_tracker.shanghai.store(true, std::sync::atomic::Ordering::Relaxed);
	}

[SozinM]

Oh, sound good!

[mattsse]

all this type does is send one single request:

https://github.com/op-rs/kona/blob/0d4886ace24afc9e51692cba7ee26ec29f73fe0b/crates/node/rpc/src/reqwest.rs#L24-L28

imo we can do all of this without pulling in the kona client dependency here

either via alloy's provider if we need websocket and HTTP support.

or we can use reqwest directly:

reth/crates/optimism/rpc/src/sequencer.rs

Lines 66 to 75 in 9cb7177

	/// Sends a POST request to the sequencer endpoint.
	async fn post_request(&self, body: String) -> Result<(), reqwest::Error> {
	self.http_client()
	.post(self.endpoint())
	.header(reqwest::header::CONTENT_TYPE, "application/json")
	.body(body)
	.send()
	.await?;
	Ok(())
	}

[SozinM]

There is also function to parse access list, but it could be taken into the reth too

[mattsse]

this error should be converted into a standalone error struct that then also implements PoolTransactionError this way we don't need this additional error variant and can use Other

[emhane]

ye, this is an op specific error, so it doesn't make sense here

[SozinM]

done

[emhane]

getting closer, some more suggestions.

also, @emhane we need to solve the kona dependency requirement, can't introduce this here

yepp, was agreed on to move required types to op-alloy remove reth dep in kona, ref op-rs/kona#1279. pending new release @refcell @clabby

[mattsse]

I think this is looking good now, I'll take a small pass over it before merging tonight, ty

[SozinM]

rebased