Merged
Conversation
mattsse
reviewed
Feb 13, 2025
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
this is fantastic
only have one suggestion
mattsse
added
A-execution
Collaborator
|
makes impl interop for op-reth a bit easier since will req tx execution without block in tx pool, nice |
klkvr
force-pushed
the
klkvr/wip-exec-transaction
branch
from
6101054 to
59546f4
Compare
klkvr
requested review from
Rjected,
fgimenez,
gakonst and
rakita
as code owners
klkvr
changed the title
BlockExecutionStrategy APIBlockExecutionStrategy API
klkvr
force-pushed
the
klkvr/wip-exec-transaction
branch
from
ba94039 to
62a41a0
Compare
klkvr
force-pushed
the
klkvr/wip-exec-transaction
branch
from
62a41a0 to
94b0408
Compare
mattsse
approved these changes
Feb 19, 2025
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
cool, this should actually give us a nice smol perf boost
| { | ||
| type Primitives = EthPrimitives; | ||
|
|
||
| type Strategy<DB: Database> = EthExecutionStrategy<DB, EvmConfig>; |
Collaborator
There was a problem hiding this comment.
imo we can erase this becasue this is intended for oneshot usage so can't think of a scenario where we would like to restrict this type
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #14578
Changes in this PR:
SystemCalleris refactored so that all its methods take anEvmas input. That way we can avoid havingEvmConfiggeneric on it, and encourage callers to reuseEvms for both transaction and system calls execution, avoiding additional allocationsBlockExecutionStrategyis refactored, changes include:This PR unlocks the following improvements:
BlockExecutionStrategymethods now require providing a full block as input making it suitable for re-use in block building. We still need an entire block to initialize the strategy though, and this can be changed by introducing a helper intermiddiate configuration struct for it. This struct would be implementation-specific and can be abstracted away like we do withEvmEnvStrategy::execute_transactionAPI without perf penalty for re-initializing EVM on every call. The benefit of this API is that it would make strategy API suitable for payload building when a set of transactions is determined dynamically and can't be passed asVec<Tx>intoexecute_transactions