chore: integrate context precompile evm example#14430
Conversation
There was a problem hiding this comment.
UX wise it would be a lot simpler if we didn't have to deal with inspectors on this level, then we could also get rid of create_evm_with_inspector function here entirely.
not a blocker, but it illustrates why dealing with NooPInspector on this level feels strange
There was a problem hiding this comment.
This feels possible and look like a proper way to do things, but needs to be cleared in Revm.
There was a problem hiding this comment.
Have added a issue here: bluealloy/revm#2069 it shouldn't take a lot of time and if it is quick fix i will do it tomorrow
There was a problem hiding this comment.
like this should just be self.create_evm(db, input).with_insp(inspector)
There was a problem hiding this comment.
Hm maybe it is even possible now, let me check
There was a problem hiding this comment.
Yep, it is possible, have changed the code
There was a problem hiding this comment.
naming nit PrecompileErrors -> PrecompileError
There was a problem hiding this comment.
|
hm op still needs to be integrated among others. |
klkvr
force-pushed
the
rakita/new-revm
branch
2 times, most recently
from
05c48cf to
4c476a0
Compare
klkvr
force-pushed
the
klkvr/new-revm
branch
from
4619a86 to
99dedb9
Compare
klkvr
force-pushed
the
rakita/new-revm
branch
13 times, most recently
from
664b80c to
2f5ba39
Compare
klkvr
force-pushed
the
klkvr/new-revm
branch
from
42dea77 to
0f24406
Compare
klkvr
force-pushed
the
rakita/new-revm
branch
from
2f5ba39 to
5063526
Compare
klkvr
force-pushed
the
rakita/new-revm
branch
from
5063526 to
9eb6f5a
Compare
klkvr
force-pushed
the
klkvr/new-revm
branch
from
4743328 to
eda1499
Compare
klkvr
force-pushed
the
rakita/new-revm
branch
from
9eb6f5a to
caae781
Compare
klkvr
force-pushed
the
rakita/new-revm
branch
2 times, most recently
from
0137ee7 to
05241e3
Compare
klkvr
force-pushed
the
klkvr/new-revm
branch
from
03bcafd to
7de9b53
Compare
examples/custom-evm/Cargo.toml
Outdated
klkvr
force-pushed
the
rakita/new-revm
branch
from
36fce96 to
2241e65
Compare
examples/custom-evm/Cargo.toml
Outdated
There was a problem hiding this comment.
yeah no need for once_cell here
klkvr
force-pushed
the
klkvr/new-revm
branch
from
59f1511 to
7ef8ecd
Compare
klkvr
force-pushed
the
rakita/new-revm
branch
from
2241e65 to
874d893
Compare
klkvr
force-pushed
the
rakita/new-revm
branch
from
874d893 to
60b6158
Compare
5 participants
Based on #14115
Updates examples for latest revm
Example is slightly changed to cache all precompiles calls as it feels like a better example.