feat(op, txpool): impl send_raw_tx_cond endpoint#14311
Merged
Conversation
fgimenez
added
A-rpc
mattsse
requested changes
Feb 7, 2025
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
good start,
the state validation stuff we can do later.
a few suggestions
fgimenez
force-pushed
the
fgimenez/impl-send-raw-tx-cond-endpoint
branch
3 times, most recently
from
039ee6c to
69661e8
Compare
mattsse
requested changes
Feb 10, 2025
fgimenez
force-pushed
the
fgimenez/impl-send-raw-tx-cond-endpoint
branch
from
9b28846 to
cd2d120
Compare
fgimenez
force-pushed
the
fgimenez/impl-send-raw-tx-cond-endpoint
branch
from
4b9ce95 to
fb1cedf
Compare
mattsse
approved these changes
Feb 10, 2025
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
this lgtm
we can add support for submitting the tx with conditional into the pool as followup
Comment on lines
99
to
102
| // otherwise, add to pool | ||
| let hash = self.pool().add_transaction(TransactionOrigin::External, tx).await.map_err( | ||
| |e| OpEthApiError::Eth(reth_rpc_eth_types::EthApiError::PoolError(e.into())), | ||
| )?; |
Collaborator
There was a problem hiding this comment.
I don't think we can submit it like this, because this now removes the conditional?
let's say this is the sequencer instance, then this now simply inserts the tx as regular tx?
Member
Author
There was a problem hiding this comment.
yep exactly, added todo comment
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #14194