Skip to content

test: Add ValidBlocks and InvalidBlocks blockchain tests#13870

Closed
VolodymyrBg wants to merge 1 commit intoparadigmxyz:mainfrom
VolodymyrBg:reth
Closed

test: Add ValidBlocks and InvalidBlocks blockchain tests#13870
VolodymyrBg wants to merge 1 commit intoparadigmxyz:mainfrom
VolodymyrBg:reth

Conversation

@VolodymyrBg
Copy link
Contributor

Implements the TODO in tests.rs by adding test coverage for ValidBlocks and InvalidBlocks test suites from the Ethereum test cases. This enhances our test coverage by including these important blockchain test cases that verify valid and invalid block processing.

The implementation:

  • Adds a new blockchain_test! macro for running blockchain tests
  • Creates a new blockchain_tests module
  • Implements tests for both ValidBlocks and InvalidBlocks test suites

Implements the TODO in tests.rs by adding test coverage for ValidBlocks and 
InvalidBlocks test suites from the Ethereum test cases. This enhances our test 
coverage by including these important blockchain test cases that verify valid 
and invalid block processing.

The implementation:
- Adds a new blockchain_test! macro for running blockchain tests
- Creates a new blockchain_tests module
- Implements tests for both ValidBlocks and InvalidBlocks test suites
@VolodymyrBg VolodymyrBg requested a review from gakonst as a code owner January 19, 2025 19:25
@emhane emhane added the C-test A change that impacts how or what we test label Jan 22, 2025
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty,
mind reoping this from a valid branch so we can push edits while we're looking at the failing tests #13969

@mattsse
Copy link
Collaborator

mattsse commented Jan 24, 2025

can

@mattsse mattsse closed this Jan 24, 2025
@VolodymyrBg VolodymyrBg deleted the reth branch March 2, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-test A change that impacts how or what we test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants