Add DA estimation to OP builder#13590
Closed
tomasmilukas wants to merge 8 commits intoparadigmxyz:mainfrom
tomasmilukas:da-estimation-builder
Closed
Add DA estimation to OP builder#13590tomasmilukas wants to merge 8 commits intoparadigmxyz:mainfrom tomasmilukas:da-estimation-builder
tomasmilukas wants to merge 8 commits intoparadigmxyz:mainfrom
tomasmilukas:da-estimation-builder
Conversation
tomasmilukas
requested review from
Rjected,
fgimenez and
mattsse
as code owners
Contributor
Author
|
Hey @mattsse, lmk if this PR addresses the issue appropriately. If its completely off track, I can just close the PR. But idm revamping it if you give me some pointers! |
Contributor
|
hey @tomasmilukas - didn't see this PR when I started working on this, but curious why this PR was closed. I'm working on something similar here: #13757 |
Contributor
Author
|
Hey @meyer9, i closed it because it didnt get attention from the paradigm team, no other reason :). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempts to close #13131.
Not sure this fully addresses, looking for feedback :). Main concern is that calldata is not enough to estimate DA size, but not sure what other metadata to include. Will investigate further by going through the OP codebase.