Skip to content

dev: swap_remove #11405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattsse merged 2 commits into from
Oct 2, 2024
Merged

dev: swap_remove #11405

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5554f86
replace remove with swap_remove
greged93 Oct 2, 2024
1670dbf
Update crates/net/network/src/test_utils/testnet.rs
greged93 Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/net/downloaders/src/headers/reverse_headers.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,7 +383,7 @@ where
.into())
}

let sealed_target = headers.remove(0).seal_slow();
let sealed_target = headers.swap_remove(0).seal_slow();
Copy link
Collaborator

@mattsse mattsse Oct 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is fine because we only need the first one and aren't using it anymore

let (header, seal) = sealed_target.into_parts();
let target = SealedHeader::new(header, seal);

Expand Down
2 changes: 1 addition & 1 deletion crates/payload/builder/src/service.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ where
let (fut, keep_alive) = self.payload_jobs[job].0.resolve();

if keep_alive == KeepPayloadJobAlive::No {
let (_, id) = self.payload_jobs.remove(job);
let (_, id) = self.payload_jobs.swap_remove(job);
Copy link
Collaborator

@mattsse mattsse Oct 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is also fine because we always find the index first and the ordering doesn't matter

trace!(%id, "terminated resolved job");
}

Expand Down