Conversation
mattsse
added
C-enhancement
mattsse
approved these changes
Sep 24, 2024
Comment on lines
+44
to
+45
| /// Type that validates the payloads sent to the engine. | ||
| pub trait EngineValidator<Types: EngineTypes>: Clone + Send + Sync + Unpin + 'static { |
Comment on lines
34
to
45
| /// Validator for the ethereum engine API. | ||
| #[derive(Debug, Clone)] | ||
| pub struct EthereumEngineValidator { | ||
| chain_spec: Arc<ChainSpec>, | ||
| } | ||
|
|
||
| impl EthereumEngineValidator { | ||
| /// Instantiates a new validator. | ||
| pub const fn new(chain_spec: Arc<ChainSpec>) -> Self { | ||
| Self { chain_spec } | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
can we move this below the trait impls on EthEngineTypes
| EthereumNetworkBuilder, | ||
| EthereumExecutorBuilder, | ||
| EthereumConsensusBuilder, | ||
| EthereumEngineValidatorBuilder, |
Collaborator
There was a problem hiding this comment.
this is fine for now, I think we'd like to not have this as a component because this is engine API specific, but for now this is totally fine since it unblocks things and the change is not invasive
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref #11054
Adds new node component
EngineValidatorand moves validation methods fromEngineTypesandPayloadAttributesto it, making those traits independent ofChainSpec