feat: use alloy Signature type#10758
Merged
emhane merged 31 commits intoparadigmxyz:mainfrom Sep 23, 2024
Merged
Conversation
klkvr
reviewed
Sep 17, 2024
| } | ||
| let signature_hash = self.signature_hash(); | ||
| self.signature.recover_signer(signature_hash) | ||
| recover_signer(&self.signature, signature_hash) |
Collaborator
|
cool, once ready I can do a new alloy patch so we have the parity checks |
Collaborator
onbjerg
approved these changes
Sep 23, 2024
Collaborator
onbjerg
left a comment
onbjerg
left a comment
There was a problem hiding this comment.
lgtm, but we should take care to test this on an existing db (as with other prim type changes) before next release to ensure we didn't break the db
Collaborator
you mean sync a node from scratch? can do |
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 22, 2026
Co-authored-by: Emilia Hane <elsaemiliaevahane@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10750