fix(reth-evm-ethereum): no_std test compilation errors#10602
fix(reth-evm-ethereum): no_std test compilation errors#10602martinezjorge wants to merge 2 commits intoparadigmxyz:mainfrom
Conversation
shekhirin
left a comment
There was a problem hiding this comment.
It's a step in the right direction, and we will need this. This doesn't fully fix the compilation for no_std, because the crate still depends on c-kzg.
| reth-etl = { path = "crates/etl" } | ||
| reth-evm = { path = "crates/evm" } | ||
| reth-evm-ethereum = { path = "crates/ethereum/evm" } | ||
| reth-evm-ethereum = { path = "crates/ethereum/evm", default-features = false } |
There was a problem hiding this comment.
given that, we don't enable the std feature anywhere in the project. @mattsse we should propagate this change to all crates that use reth-evm-ethereum as a dependency, so they enable the std feature of it, right?
There was a problem hiding this comment.
The following dependencies in reth-evm-ethereum have c-kzg as default features:
reth-primitivesreth-revm
As far as I can tell, it seems that these are the main culprits; although, the rabbit hole may go deeper. Going off of #9430, would the move be to go from c-kzg -> kzg-rs in the reth-primitives and reth-revm?
|
Thank you for the review. I'm happy to wait to see what @mattsse says in regards to setting I wasn't exactly aiming to progress #10088 in this PR but I'm happy to make it the focus. I was mostly aiming in this PR to just get the failing tests to pass when running it with the In regards to
to run successfully? |
Towards #10088
In
reth-evm-ethereumThe tests fail when running:
cargo t -p reth-evm-ethereum --no-default-featuresThese changes fix the compilation issues