Merged
Conversation
Adds the Incident Response Improvements security review by offbeat labs.
…e subcmd (ethereum-optimism#14488) * feat: op-deployer clean cache command Signed-off-by: Yashvardhan Kukreja <yashvardhan@oplabs.co> * lint Signed-off-by: Yashvardhan Kukreja <yashvardhan@oplabs.co> * chore: cleaner dealing with test dir Signed-off-by: Yashvardhan Kukreja <yashvardhan@oplabs.co> * chore: refactor the IsolatedTestDirWithAutoCleanup and break import cycle Signed-off-by: Yashvardhan Kukreja <yashvardhan@oplabs.co> * chore: small cleanup Signed-off-by: Yashvardhan Kukreja <yashvardhan@oplabs.co> --------- Signed-off-by: Yashvardhan Kukreja <yashvardhan@oplabs.co>
…ereum-optimism#14493) * feat(op-program-svc): introduce new service to compute prestates * test(op-program-svc): add tests * Update kurtosis-devnet/op-program-svc/README.md Co-authored-by: Inphi <mlaw2501@gmail.com> --------- Co-authored-by: Inphi <mlaw2501@gmail.com>
…um-optimism#14489) * op-service: make signer client compatible with SetCodeTx type * use hexutil.U256 instead of hexutil.Big * add explanatory comments * Fix authorizationList json tag Co-authored-by: protolambda <proto@protolambda.com> * use helper fcn with panic for big.Int to uint256.Int * use uint256.MustFromBig instead of custom helper --------- Co-authored-by: protolambda <proto@protolambda.com>
…ptimism#14523) Cleans up the security reviews table because it had some errors and a few missing entries. Updates codeowners so that the security reviewers team can merge into the docs folder.
* Treat non-zero vm exits as a special case * Only handle panics as a special case * Add more tests * Record panic metrics * Tweak error message
Updates the OptimismPortal to not alias 7702 addresses. Updates several other contracts to use a standard library for checking if the msg sender is an EOA.
…essBlocks()` (ethereum-optimism#14520) * op-batcher: always updateCursorAndMetrics when returning from processBlocks() * Update op-batcher/batcher/channel_manager.go Co-authored-by: Sebastian Stammler <seb@oplabs.co> --------- Co-authored-by: Sebastian Stammler <seb@oplabs.co>
…4514) * fix: Unique markers for devnet-sdk * chore: Add a test
…-optimism#14516) * op-challenger: Avoid loading duplicate leaves. * op-challenger: Sanity check length of fetched input data. Provides a clearer error message if the fetch is incorrect rather than just InvalidProof() revert reason. * op-challenger: Deduplicate blocks in contract bindings. * Deduplicate block numbers in test setup now that the contract bindings handle it. * Fix more tests.
…ptimism#14534) Adds semgrep rules and a new golang contracts check for reinitializer modifiers. Important safety checks now that we are using upgrade functions.
* all: update op-geth to v1.101500.1 * op-batcher,op-e2e/system: Take floor data gas into account, fix AutoDA test Fixes ethereum-optimism#14513 * Fix EIP-2935 implementation and tests * op-program/client/l2: Fix chainContext.Config() to return actual cfg * op-program/client/l2/test: Nilify chain config blob schedule * update op-geth v1.101500.2-synctest.4 * Replace IntrinsicGas with FloorDataGas for calldata estimations * Remove static MaxBlobsPerBlobTx constant * update op-geth/v1.101500.2-rc.1 * revert usage of params.HistoryServeWindow
* op-supervisor: Check message expiry * add safe_update tests * fix override expiry window description * log warn when overriding expiry window * lint * fix tests * Fix supervisor_checkMessages; use ErrConflict * tweak supervisor_checkMessages API * add supervisor_checkMessagesV2 * update op-geth dependency * move override to depset config; fix checkMessagev1 * go.mod: drop diff again, op-geth was updated in develop branch --------- Co-authored-by: protolambda <proto@protolambda.com>
* op-challenger: Add Super DG contract caller * op-dispute-mon: Support Super FDG game types
…thereum-optimism#14554) * op-node: Remove OverrideMessageExpiryTimeInterop from rollup.Config * fix test fixture
…hannel timeout log (ethereum-optimism#14553) * op-batcher: remove ChannelManager.CheckExpectedProgress * op-batcher: add warning log when a channel times out on chain
…d()` (ethereum-optimism#14561) * op-batcher: correctly track block metrics in handleChannelInvalidated Includes test which fails without the fix. * op-batcher: log out channels which are dropped during handleChannelInvalidated() * change to warn log for dropped channels
…m-optimism#14719) * Fix problem with kurtosis-devnet deploy * Add NAT test for Isthmus withdrawal root header
* Fix problem with kurtosis-devnet deploy * Add devnet-sdk port of op-e2e fees_test.go
* Fix problem with kurtosis-devnet deploy * Port Fjord check scripts op-e2e test to devnet-sdk
* Fix problem with kurtosis-devnet deploy * Add devnet-sdk port of op-e2e erc20_bridge_test.go
…timism#14413) This is a temporary measure, until we can integrate a proofs-only fileserver with the op-challenger deployment. But in the meantime, this unblocks a decent amount of idempotent kurtosis deployments, by avoiding kurtosis invalidating the execution cache needlessly.
* feat: interop portal fast follow 1 First set of fast-follow changes to the interop portal. * fix: PR review feedback
* feat: update operator fee contract bytecodes * feat: add Isthmus contracts version check
…ptimism#14770) This change introduces a trampoline package that we can use to pin the (transitive) dependencies of our optimism package.
…thereum-optimism#14796) De-duplicate iteration of each hard fork between Description and LogDescription
* op-deployer: Clarify versioning docs * Apply suggestions from code review --------- Co-authored-by: Matt Solomon <matt@mattsolomon.dev>
* fix(op-deployer): default cache dir * add explanatory fallback log
* feat: interop fixes (ethereum-optimism#287) * feat: interop fixes * fix: natspec format * chore: add field on struct natspec --------- Co-authored-by: 0xDiscotech <131301107+0xDiscotech@users.noreply.github.com> * fix: campaign fixes (ethereum-optimism#313) * feat: interop fixes * fix: permit2 not inifinite approval check * chore: enhance superchain erc20 natspec * chore: tests natspec * fix: incorrect merge --------- Co-authored-by: agusduha <agusnduha@gmail.com> * chore: remove interop contracts (ethereum-optimism#318) * chore: remove unnecessary interop contracts * fix: golang tests * chore: remove system config interop and run pre pr * fix: exlude correct contracts on test to succeed * chore: update initializer array length * fix: semver lock * fix: L2 audit findings (ethereum-optimism#323) * fix: audit findings * chore: pre-pr * refactor: avoid stack too deep removing params on test (ethereum-optimism#324) --------- Co-authored-by: AgusDuha <81362284+agusduha@users.noreply.github.com> Co-authored-by: agusduha <agusnduha@gmail.com>
* ctb/validator: Add v3.0.0 validator * use exp import * ci fixes * fix slice sort * add operator fee validation * fix tests
* add twrap in just * rerun ci
…thereum-optimism#14510) Bumps [github.com/google/go-cmp](https://github.com/google/go-cmp) from 0.6.0 to 0.7.0. - [Release notes](https://github.com/google/go-cmp/releases) - [Commits](google/go-cmp@v0.6.0...v0.7.0) --- updated-dependencies: - dependency-name: github.com/google/go-cmp dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Yashvardhan Kukreja <yashvardhan@oplabs.co>
* add unichain mainnet * bump superchain registry and refactor parser * json to toml * correct typo * fmt * add permissions * try hardcoded key * escape * test * superchain-ops like fix * select standard validation version * fmt * update version * change test to ink * build base cache * uni, ink base and op * bump superchain registry * bump registry * skip op test on other chains * fmt * skip non-op test for non-op chains * fmt * fix tests of conflicts * remove console import * remove correct import * util function
Previously, any deployment using tagged releases on an official chain like Sepolia would use the predeployed OPCM. The predeployed OPCM would point these chains to the global `SuperchainConfig`, which may not have been the intended behavior. This PR updates the logic in the deployment pipeline to use the global `SuperchainConfig` under the following conditions: 1. The user specifies intent type `standard`. 2. The user specifies intent type `standard-overrides` and does not modify the Superchain roles.
…imism#14820) * feat: remove DisputeGameFactory input from SystemConfig Updates the SystemConfig to kill the DisputeGameFactory input. By getting this address from the OptimismPortal we can remove the need for unnecessary inputs that would have to be changed if the DisputeGameFactory changes. * fix: make tests work * fix: remove console log * fix: move address fetch * fix: address pr feedback * fix: missing semicolon * chore: remove DISPUTE_GAME_FACTORY_SLOT * test: fix abi spec --------- Co-authored-by: Matt Solomon <matt@mattsolomon.dev>
Also splits and fixes fee NAT tests.
* update op-geth dependency * update scr submodule
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Obtained by running
and fixing conflicts