Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: iceberg metadata comp codec #143

Merged

Conversation

rakesh-tmdc
Copy link
Contributor

What

Adding support to pass option in iceberg read for metadata compression codec

Why

It will allow users to read iceberg files for which metadata is compressed.

@CLAassistant
Copy link

CLAassistant commented Sep 30, 2024

CLA assistant check
All committers have signed the CLA.

@rakesh-tmdc rakesh-tmdc changed the title Feat/iceberg metadata comp codec feat: iceberg metadata comp codec Sep 30, 2024
@rakesh-tmdc rakesh-tmdc changed the title feat: iceberg metadata comp codec fix: iceberg metadata comp codec Sep 30, 2024
Copy link
Collaborator

@philippemnoel philippemnoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you. Could you please:

1- Write a test for this feature
2- Add a documentation edit in paradedb/paradedb under docs/ingest?

Thank you 🙏

@philippemnoel
Copy link
Collaborator

This looks great, thank you. Could you please:

1- Write a test for this feature 2- Add a documentation edit in paradedb/paradedb under docs/ingest?

Thank you 🙏

Bump on the documentation @rakesh-tmdc

Signed-off-by: Philippe Noël <[email protected]>
@philippemnoel philippemnoel merged commit 0a47f64 into paradedb:dev Oct 8, 2024
11 checks passed
@rakesh-tmdc rakesh-tmdc deleted the feat/iceberg-metadata-comp-codec branch October 11, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants