Remove obsolete embedded RootCA bundle #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes an embedded RootCA bundle that hasn't been necessary for quite a while. All Papertrail syslog endpoints provide full certificate chains that validate in any modern OS.
Even if this bundle was needed for some operating system, the current logic wouldn't be effective because it only kicks in for
logs.papertrailapp.com, which only accounts for ~15% of customer port assignments these days. We haven't heard any complaints about the other six destinations, so it's safe to assume they've all been working fine without it.Tested to confirm that I can still send to various Papertrail destinations afterwards. Also used
openssl s_client -showcertsto confirm all of Papertrail's destinations present the same certificate chain.