-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps update #190
deps update #190
Conversation
angular-leaflet-directive has a new release, do you want to update? |
Due to the updates, we now get a warning on the console reading
I wasn't able to resolve it at this point, but re can worry about it later. |
This is the copyright/license information tooltip. I'll prepare a commit later... |
Yeap right. When I simply use
upon clicking on the tooltip. |
With tooltip-template, the attribution directive doesn't require any business logic any more: it's a simple template! \o/
The tooltip warning is gone by using But there are still issues that need to be resolved before merging:
|
angular-bootstrap 0.13.2 was released yesterday. It remains to check if all of our issues are solved with the new release. :) |
The carousel works again but not as expected (content slides to the wrong side). The log messages remain. @nschloe does it break anything? :) |
For me, the carousel does work as expected. |
The latest update brings a proper carousel fix. |
The pdf.js warning is reported at mozilla/pdf.js#6306. |
Apparently, it's expected normal to get the warning, cf. mozilla/pdf.js#6306 (comment). Since the typeahead deprecation warning is also being worked on, I'd consider this PR good to go for now. |
Alright, now MathJax brings in an error when comments are rendered on, see here. It tries to load
|
Upstream claims "this isn't an error", cf. mathjax/MathJax#926. |
We might want to wait for leaflet to release, cf. here and