Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tag searching #682

Merged
merged 2 commits into from
Mar 24, 2021
Merged

Add tag searching #682

merged 2 commits into from
Mar 24, 2021

Conversation

imjared
Copy link
Contributor

@imjared imjared commented Mar 24, 2021

Description

Issue

#571

Screenshots

image
image

Checklist

  • Everything passes when running mix test
  • Ran mix format
  • No frontend compilation warnings

@imjared
Add tag searching
c1feb81 
- remove state.isRefreshing since it's unused
reichert621
reichert621 approved these changes Mar 24, 2021
View reviewed changes
Copy link
Collaborator

@reichert621 reichert621 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@imjared thanks for handling this! 🎉

@reichert621 reichert621 merged commit 9a90c75 into papercups-io:master Mar 24, 2021
a8t pushed a commit to a8t/papercups that referenced this pull request Mar 28, 2021
@imjared
Add tag searching (papercups-io#682)
91e0cf2 
* Add tag searching
- remove state.isRefreshing since it's unused

* Run prettier
@imjared imjared deleted the tag-search branch July 27, 2021 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reichert621 reichert621 reichert621 approved these changes

@reuben581 reuben581 reuben581 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@imjared @reichert621 @reuben581