Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change license to LGPL #26

Open
gautierhattenberger opened this issue Jul 13, 2016 · 32 comments
Open

Change license to LGPL #26

gautierhattenberger opened this issue Jul 13, 2016 · 32 comments

Comments

@gautierhattenberger
Copy link
Member

Changing the license of PPRZLINK to LGPL (with proper exceptions for static linking https://en.wikipedia.org/wiki/GPL_linking_exception) would make integration into non-GPL code easier.

Below is a list (maybe not complete yet) of contributors extracted from git + file headers, for the current pprzlink repository and also from the former code previously integrated to Paparazzi (paparazzi/paparazzi@22ca426 and before)

#### PAPARAZZI ####
git ls-tree -r -z --name-only HEAD -- conf/messages.* conf/units.xml sw/tools/generators/gen_messages.ml sw/airborne/subsystems/datalink/*transport* sw/airborne/subsystems/datalink/xbee* sw/airborne/subsystems/datalink/uart_print.h sw/lib/python/**/* sw/lib/ocaml/pprz.ml* sw/lib/ocaml/xbee.ml* sw/lib/ocaml/serial.ml* sw/lib/ocaml/logpprz.ml* sw/lib/ocaml/convert.c | xargs -0 -n1 git blame --line-porcelain HEAD |grep  "^author "|sort|uniq -c|sort -nr 
   3591 author Felix Ruess
   1882 author Gautier Hattenberger
   1718 author Pascal Brisset
   1169 author Antoine Drouin
    218 author Martin Mueller
    217 author Allen Ibara
    129 author Christophe De Wagter
     82 author Freek van Tienen
     61 author John Stowers
     27 author podhrmic
     27 author Cameron Lee
     26 author Oswald Berthold
     20 author Ewoud Smeur
     16 author dewagter
     15 author fvantienen
     12 author kirkscheper
     11 author Bruzzlee
      9 author Loic Drumettaz
      9 author Allen
      6 author Stephen Dwyer
      5 author Tobias Muench
      5 author LodewijkSikkel
      5 author agressiva
      4 author Pranay Sinha
      4 author karlito139
      3 author Paul Cox
      3 author guidoAI
      2 author Roland Meertens
      2 author rad
      2 author [email protected]
      2 author Christoph Niemann
      1 author OSAM-UAV Team
      1 author Louis Dugrain
      1 author Eric Parsonage

grep "Copyright" conf/messages.* conf/units.xml sw/tools/generators/gen_messages.ml sw/airborne/subsystems/datalink/*transport* sw/airborne/subsystems/datalink/xbee* sw/airborne/subsystems/datalink/uart_print.h sw/lib/python/**/* sw/lib/ocaml/pprz.ml* sw/lib/ocaml/xbee.ml* sw/lib/ocaml/serial.ml* sw/lib/ocaml/logpprz.ml* sw/lib/ocaml/convert.c 
sw/tools/generators/gen_messages.ml: * Copyright (C) 2003-2008 ENAC, Pascal Brisset, Antoine Drouin
sw/airborne/subsystems/datalink/downlink_transport.h: * Copyright (C) 2003-2010 The Paparazzi Team
sw/airborne/subsystems/datalink/ivy_transport.c: * Copyright (C) 2003  Pascal Brisset, Antoine Drouin
sw/airborne/subsystems/datalink/ivy_transport.c: * Copyright (C) 2014  Gautier Hattenberger <[email protected]>
sw/airborne/subsystems/datalink/ivy_transport.h: * Copyright (C) 2003  Pascal Brisset, Antoine Drouin
sw/airborne/subsystems/datalink/ivy_transport.h: * Copyright (C) 2014  Gautier Hattenberger <[email protected]>
sw/airborne/subsystems/datalink/pprzlog_transport.c: * Copyright (C) 2014 Gautier Hattenberger <[email protected]>
sw/airborne/subsystems/datalink/pprzlog_transport.h: * Copyright (C) 2014 Gautier Hattenberger <[email protected]>
sw/airborne/subsystems/datalink/pprz_transport.c: * Copyright (C) 2006  Pascal Brisset, Antoine Drouin
sw/airborne/subsystems/datalink/pprz_transport.c: * Copyright (C) 2014  Gautier Hattenberger <[email protected]>
sw/airborne/subsystems/datalink/pprz_transport.h: * Copyright (C) 2003  Pascal Brisset, Antoine Drouin
sw/airborne/subsystems/datalink/pprz_transport.h: * Copyright (C) 2014  Gautier Hattenberger <[email protected]>
sw/airborne/subsystems/datalink/transport.h: * Copyright (C) 2011-2014 Gautier Hattenberger <[email protected]>
sw/airborne/subsystems/datalink/xbee24.h: * Copyright (C) 2009  ENAC, Pascal Brisset
sw/airborne/subsystems/datalink/xbee24.h: * Copyright (C) 2014  Gautier Hattenberger <[email protected]>
sw/airborne/subsystems/datalink/xbee868.h: * Copyright (C) 2009  ENAC, Pascal Brisset
sw/airborne/subsystems/datalink/xbee868.h: * Copyright (C) 2014  Gautier Hattenberger <[email protected]>
sw/airborne/subsystems/datalink/xbee.c: * Copyright (C) 2006  Pascal Brisset, Antoine Drouin
sw/airborne/subsystems/datalink/xbee.c: * Copyright (C) 2014  Gautier Hattenberger <[email protected]>
sw/airborne/subsystems/datalink/xbee.h: * Copyright (C) 2006  Pascal Brisset, Antoine Drouin
sw/airborne/subsystems/datalink/xbee.h: * Copyright (C) 2014  Gautier Hattenberger <[email protected]>
sw/airborne/subsystems/datalink/uart_print.h: * Copyright (C) 2005 Pascal Brisset, Antoine Drouin
sw/airborne/subsystems/datalink/uart_print.h: * Copyright (C) 2015 Gautier Hattenberger <[email protected]>
sw/lib/ocaml/pprz.ml: * Copyright (C) 2003 Pascal Brisset, Antoine Drouin
sw/lib/ocaml/pprz.mli: * Copyright (C) 2003 Pascal Brisset, Antoine Drouin
sw/lib/ocaml/xbee.ml: * Copyright (C) 2006 ENAC, Pascal Brisset, Antoine Drouin
sw/lib/ocaml/xbee.mli: * Copyright (C) 2006 ENAC, Pascal Brisset, Antoine Drouin
sw/lib/ocaml/serial.ml: * Copyright (C) 2004 CENA/ENAC, Pascal Brisset
sw/lib/ocaml/serial.mli: * Copyright (C) 2004 CENA/ENAC, Pascal Brisset
sw/lib/ocaml/logpprz.ml: * Copyright (C) 2003 Pascal Brisset, Antoine Drouin
sw/lib/ocaml/convert.c:   Copyright (C) 2004 Pascal Brisset, Antoine Drouin

#### PPRZLINK ####

git ls-tree -r -z --name-only HEAD -- **/* | xargs -0 -n1 git blame --line-porcelain HEAD |grep  "^author "|sort|uniq -c|sort -nr 
  10923 author Felix Ruess
   8295 author Gautier Hattenberger
    246 author Rijesh Augustine
     82 author HooperFly
     65 author kevindehecker
     50 author kirkscheper
     41 author Christophe De Wagter
     11 author Ewoud Smeur
      9 author Roland Meertens
      9 author guidoAI

Main contributors are well known and easy to reach. What about minor ones, former student and so on. Do we set a limit and where ?

@esden
Copy link
Member

esden commented Jul 13, 2016

So what might help here is creating a list of the people we know have accounts on GitHub. This way we can address at least that part of yey/ney. Also I would limit the significant contribution to anything above 5 lines of code. It is somewhat arbitrary number but looking at the commits that is where I would personally draw the line. I have tried to find some references from other projects but I was not successful finding those yet.

Also anything below 50 lines of code should be easy to replace even if people in that contribution range do not agree with the license change.

I hope I added everyone based on the criteria I mentioned before. If you know anyone who has ??? next to their name, their github account nickname or have their email address/contact please add it in the comments here so we can approach them too.

If your name is listed in that list please state in the comments that you agree with the license change from GPL to LGPL + linking exception as @gautierhattenberger mentioned. :) Then we can check off your name in the list.

@gautierhattenberger you are welcome to take over my table into your post. Maybe that is the correct place to track progress of this issue. :)

Cheers,
Piotr

@podhrmic
Copy link
Member

I have no problem with the licence change. My understanding is that this is for pprzlink only - are you considering to change the licence for the rest of pprz too?

@esden
Copy link
Member

esden commented Jul 14, 2016

As far as I understand this is only pprz link related.

@podhrmic
Copy link
Member

And I guess the motivation is so you can use pprzlink in other projects?

@esden
Copy link
Member

esden commented Jul 14, 2016

Yes this will allow other projects including closed source ones to use PPRZLink linked into their codebase. This will allow in the future for more devices and software packages to interact with paparazzi based systems. This does not change the fact that if someone makes changes to PPRZLink and distribute it in any form including binary, they will have to publish their changes to the library. But it allows them to use the library non virally.

@aibara
Copy link

aibara commented Jul 14, 2016

For what it's worth, I'd be fine with the license change.

On Jul 13, 2016 17:07, "Piotr Esden-Tempski" [email protected]
wrote:

Yes this will allow other projects including closed source ones to use
PPRZLink linked into their codebase. This will allow in the future for more
devices and software packages to interact with paparazzi based systems.
This does not change the fact that if someone makes changes to PPRZLink and
distribute it in any form including binary, they will have to publish their
changes to the library. But it allows them to use the library non virally.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#26 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAP3e2ZhYedX9myAMY8LAjaw23A_HjCAks5qVX3MgaJpZM4JL7w_
.

@fvantienen
Copy link
Member

I have no problem with the license change 👍

@rmeertens
Copy link
Contributor

I'm fine with everything.

@martinmm
Copy link
Member

Fine for me for pprzlink

@flixr
Copy link
Member

flixr commented Jul 14, 2016

I support changing the pprzlink license to LGPL with linking exception.

@gautierhattenberger
Copy link
Member Author

I indeed agree with the license change

@nzjrs
Copy link

nzjrs commented Jul 14, 2016

I agree with the license change from GPLv3 to LGPL

On 14 July 2016 at 10:42, Piotr Esden-Tempski [email protected]
wrote:

So what might help here is creating a list of the people we know have
accounts on GitHub. This way we can address at least that part of yey/ney.
Also I would limit the significant contribution to anything above 5 lines
of code. It is somewhat arbitrary number but looking at the commits that is
where I would personally draw the line. I have tried to find some
references from other projects but I was not successful finding those yet.

Also anything below 50 lines of code should be easy to replace even if
people in that contribution range do not agree with the license change.

I hope I added everyone based on the criteria I mentioned before. If you
know anyone who has ??? next to their name, their github account nickname
or have their email address/contact please add it in the comments here so
we can approach them too.

If your name is listed in that list please state in the comments that you
agree with the license change from GPLv3 to LGPL + linking exception as
@gautierhattenberger https://github.com/gautierhattenberger mentioned.
:) Then we can check off your name in the list.

@gautierhattenberger https://github.com/gautierhattenberger you are
welcome to take over my table into your post. Maybe that is the correct
place to track progress of this issue. :)

Cheers,
Piotr


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#26 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AACjo_VM8nzrYlA9elTsGrkSweTtZENaks5qVfZngaJpZM4JL7w_
.

@flixr
Copy link
Member

flixr commented Jul 14, 2016

We currently have GPLv2 (or later), updated it above...

@EwoudSmeur
Copy link
Member

I agree

@poine
Copy link

poine commented Jul 14, 2016

I agree to the proposed license change.

On Jul 14, 2016 1:55 AM, "Piotr Esden-Tempski" [email protected]
wrote:

So what might help here is creating a list of the people we know have
accounts on GitHub. This way we can address at least that part of yey/ney.
Also I would limit the significant contribution to anything above 5 lines
of code. It is somewhat arbitrary number but looking at the commits that is
where I would personally draw the line. I have tried to find some
references from other projects but I was not successful finding those yet.

Also anything below 50 lines of code should be easy to replace even if
people in that contribution range do not agree with the license change.

I hope I added everyone based on the criteria I mentioned before. If you
know anyone who has ??? next to their name, their github account nickname
or have their email address/contact please add it in the comments here so
we can approach them too.

If your name is listed in that list please state in the comments that you
agree with the license change from GPLv3 to LGPL + linking exception as
@gautierhattenberger https://github.com/gautierhattenberger mentioned.
:) Then we can check off your name in the list.

@gautierhattenberger https://github.com/gautierhattenberger you are
welcome to take over my table into your post. Maybe that is the correct
place to track progress of this issue. :)

Cheers,
Piotr


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#26 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAGTz0TAUgnQ_5QC7Su9gQ5us2fUA1_nks5qVXr0gaJpZM4JL7w_
.

@Bruzzlee
Copy link

I agree with the license change

@camlee
Copy link

camlee commented Jul 14, 2016

I agree with this license change.

@x75
Copy link

x75 commented Jul 14, 2016

i agree

@rijesha
Copy link
Contributor

rijesha commented Jul 14, 2016

I agree.

@dewagter
Copy link
Member

I agree with this license change

@kirkscheper
Copy link
Member

I agree

@LodewijkSikkel
Copy link

Agree

@TobiasMue
Copy link

I agree :-)

@guidoAI
Copy link
Contributor

guidoAI commented Jul 16, 2016

I agree

@hooperfly
Copy link
Contributor

I agree.

@agressiva
Copy link

I agree

1 similar comment
@kevindehecker
Copy link
Contributor

I agree

@scdwyer
Copy link

scdwyer commented Sep 1, 2016

Little late to the party, but I agree with and support the change in license.

@podhrmic
Copy link
Member

podhrmic commented Nov 5, 2016

What is the status here? @gautierhattenberger @esden Waiting for @Drumettaz ?

@gautierhattenberger
Copy link
Member Author

No, we may consider @Drumettaz contribution small (changing a few lines in message definition).
Actually what we (Enac) need to do to close this is to get into contact with Pascal Brisset's family.

@gautierhattenberger
Copy link
Member Author

unless someone with a good knowledge of licensing issues tells me it is not relevant here...

@podhrmic
Copy link
Member

@gautierhattenberger just a confirmation here - according to our company lawyer you were right and have to get in touch with Pascal's family to figure out to whom his copyright passed on. So no easy solution here:-/

gautierhattenberger added a commit that referenced this issue Nov 26, 2020
Add license text
Keep Ocaml, C code and generators in GPL
Python is now in LGPL as discussed in #26
gautierhattenberger added a commit that referenced this issue Dec 4, 2020
Add license text
Keep Ocaml, C code and generators in GPL
Python is now in LGPL as discussed in #26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests