Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial number of columns incorrect when in landscape #13

Closed
youjinp opened this issue Nov 19, 2019 · 1 comment
Closed

Initial number of columns incorrect when in landscape #13

youjinp opened this issue Nov 19, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@youjinp
Copy link
Contributor

youjinp commented Nov 19, 2019

Summary
When the initial device orientation is landscape, the number of columns displayed is incorrect. The correct number of columns is displayed only after rotating to portrait and landscape again.

Expected
Screen Shot 2019-11-20 at 12 31 22 PM

Actual
Screen Shot 2019-11-20 at 12 31 08 PM

Env
Xcode 11.2, iOS 13.2, Swift 5
youjinp pushed a commit to youjinp/WaterfallGrid that referenced this issue Nov 20, 2019
@youjin
Fix: issue paololeonardi#13
76428e2 
`UIDevice.current.orientation` gives "unknown" orientation

Change to use width and height to determine whether landscape or
portrait
@paololeonardi paololeonardi added the bug Something isn't working label Nov 20, 2019
paololeonardi pushed a commit that referenced this issue Nov 20, 2019
@youjinp @paololeonardi
Fix: issue #13 (#14)
6021f61 
* Fix: issue #13

`UIDevice.current.orientation` gives "unknown" orientation

Change to use width and height to determine whether landscape or
portrait

* Refactor
@paololeonardi
Copy link
Owner

@youjinp thanks for raising and fixing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@paololeonardi @youjinp