Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrote code to unzip .gz files on windows systems #28

Merged
merged 1 commit into from
Apr 12, 2017

Conversation

russodanielp
Copy link
Contributor

I added a few lines of code for this to work on Windows systems. There is probably a better way to do this like using gzip to read the xml and using elementree to parse the string, but this was more straightforward.

@panzarino
Copy link
Owner

@russodanielp Have you tested this? I can't test it myself on Windows, but if it works for you, I'll merge it in soon.

@russodanielp
Copy link
Contributor Author

Yeah works on my machine....also would be available to troubleshoot any issues windows users may have.

Also, is there any documentation for the GameDay XML data provided by MLB? I'm kinda going through your code to figure it out currently....

@panzarino
Copy link
Owner

panzarino commented Apr 12, 2017

@russodanielp I haven't found any docs on the XML files, I just did my best to understand what everything is.

@russodanielp
Copy link
Contributor Author

@panzarino Okay thanks...I am writing some code to make querying by player a bit easier. Would this be something you would be interested in incorporating?

@panzarino panzarino merged commit b11e90f into panzarino:dev Apr 12, 2017
@panzarino
Copy link
Owner

@russodanielp yes definitely, I would really appreciate it. Please do submit a PR if you are able to make it easier.

I'll push a release within the next couple of days with these changes.

@russodanielp
Copy link
Contributor Author

@panzarino okay. I believe after looking in your code there is no way to directly get batting stats for a player right?

@panzarino
Copy link
Owner

@russodanielp other than by selecting the game and then player stats and then batter stats, there is no other way to get stats for a single player right now.

@panzarino
Copy link
Owner

Released in 2.3.2.

@panzarino
Copy link
Owner

panzarino commented Jun 25, 2017

@russodanielp if you want to continue contributing in the future, I have set up a mlbgame Slack that you can join through this link: https://mlbgame-slack-invite.herokuapp.com/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants