supportPKCE return value is incorrect

[mo36924]

What happened?

supportsPKCE return value is incorrect.

openid-client/src/index.ts

Lines 1464 to 1472 in ff1436e

	supportsPKCE: {
	__proto__: null,
	value(method = 'S256') {
	return (
	metadata.code_challenge_methods_supported?.includes(method) !== true
	)
	},
	},
	}

The following code may be more correct.

metadata.code_challenge_methods_supported?.includes(method) === true 

Version

v6.1.0

Runtime

Node.js

Runtime Details

v20.17.0

Code to reproduce

import { equal } from "node:assert";
import { discovery } from "openid-client";

const config = await discovery(new URL("https://accounts.google.com"), "clientId", "clientSecret");
equal(config.serverMetadata().code_challenge_methods_supported?.includes("S256"), true);
// The following line throws an error
equal(config.serverMetadata().supportsPKCE(), true);

Required

• I have searched the issues tracker and discussions for similar topics and couldn't find anything related.
• I agree to follow this project's Code of Conduct

[panva]

Damn you're right, i took the code from my previous examples that was checking for anything but true.

[panva]

Fixed in https://github.com/panva/openid-client/releases/tag/v6.1.1