Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always use an explicit ubuntu image #21867

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

cburroughs
Copy link
Contributor

The release of 2.24.0rc2 failed:
https://github.com/pantsbuild/pants/actions/runs/12909883768/job/36005845441#step:3:19

  Version 3.7 was not found in the local cache
  Error: The version '3.7' with architecture 'x64' was not found for Ubuntu 24.04.
  The list of all available versions can be found here: https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json

This is because the publish step was running on ubuntu-latest which GitHub recently switched from Ubuntu 24
to 22. actions/runner-images#10636 Which has a different set of GitHub Python versions
https://github.com/actions/python-versions available.

Setting to an explicit image version lets us control the upgrade cadence instead of rugs being pulled out from under.

The release of `2.24.0rc2` failed:
https://github.com/pantsbuild/pants/actions/runs/12909883768/job/36005845441#step:3:19
```
  Version 3.7 was not found in the local cache
  Error: The version '3.7' with architecture 'x64' was not found for Ubuntu 24.04.
  The list of all available versions can be found here: https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json
```

This is because the `publish` step was running on `ubuntu-latest`
which GitHub recently switched from Ubuntu 24
to 22. actions/runner-images#10636 Which has
a different set of GitHub Python versions
<https://github.com/actions/python-versions> available.

Setting to an explicit image version lets us control the upgrade
cadence instead of rugs being pulled out from under.
@cburroughs cburroughs self-assigned this Jan 22, 2025
@cburroughs cburroughs added this to the 2.24.x milestone Jan 22, 2025
@cburroughs cburroughs added the release-notes:not-required PR doesn't require mention in release notes label Jan 22, 2025
Copy link
Contributor

@huonw huonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@cburroughs cburroughs enabled auto-merge (squash) January 22, 2025 21:00
@cburroughs cburroughs merged commit 0ee9a16 into pantsbuild:main Jan 22, 2025
24 checks passed
@WorkerPants
Copy link
Member

I tried to automatically cherry-pick this change back to each relevant milestone, so that it is available in those older releases of Pants.

✔️ 2.24.x

Successfully opened #21868.


Thanks again for your contributions!

🤖 Beep Boop here's my run link

@WorkerPants
Copy link
Member

I tried to automatically cherry-pick this change back to each relevant milestone, so that it is available in those older releases of Pants.

✔️ 2.23.x

Successfully opened #21869.

✔️ 2.24.x

Successfully opened #21868.


Thanks again for your contributions!

🤖 Beep Boop here's my run link

cburroughs added a commit that referenced this pull request Jan 22, 2025
The release of `2.24.0rc2` failed:

https://github.com/pantsbuild/pants/actions/runs/12909883768/job/36005845441#step:3:19
```
  Version 3.7 was not found in the local cache
  Error: The version '3.7' with architecture 'x64' was not found for Ubuntu 24.04.
  The list of all available versions can be found here: https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json
```

This is because the `publish` step was running on `ubuntu-latest` which
GitHub recently switched from Ubuntu 24
to 22. actions/runner-images#10636 Which has a
different set of GitHub Python versions
<https://github.com/actions/python-versions> available.

Setting to an explicit image version lets us control the upgrade cadence
instead of rugs being pulled out from under.

Co-authored-by: cburroughs <[email protected]>
cburroughs added a commit that referenced this pull request Jan 22, 2025
The release of `2.24.0rc2` failed:

https://github.com/pantsbuild/pants/actions/runs/12909883768/job/36005845441#step:3:19
```
  Version 3.7 was not found in the local cache
  Error: The version '3.7' with architecture 'x64' was not found for Ubuntu 24.04.
  The list of all available versions can be found here: https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json
```

This is because the `publish` step was running on `ubuntu-latest` which
GitHub recently switched from Ubuntu 24
to 22. actions/runner-images#10636 Which has a
different set of GitHub Python versions
<https://github.com/actions/python-versions> available.

Setting to an explicit image version lets us control the upgrade cadence
instead of rugs being pulled out from under.

Co-authored-by: cburroughs <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:not-required PR doesn't require mention in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants