Skip to content

Fix release script #19291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benjyw merged 1 commit into from
Jun 11, 2023
Merged

Fix release script #19291

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions build-support/bin/_release_helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,10 +66,6 @@
"pantsbuild.pants.testinfra",
]

_expected_owners = {"benjyw", "John.Sirois", "stuhood"}

_expected_maintainers = {"EricArellano", "illicitonion", "wisechengyi", "kaos"}


# Disable the Pants repository-internal internal_plugins.test_lockfile_fixtures plugin because
# otherwise inclusion of that plugin will fail due to its `pytest` import not being included in the pex.
Expand Down Expand Up @@ -809,14 +805,6 @@ def build_pex(fetch: bool) -> None:
dest = stable_dest
green(f"Built {dest}")

# We filter out Pants options like `PANTS_CONFIG_FILES` and disable certain internal backends.
env = {k: v for k, v in env.items() if not k.startswith("PANTS_")}
env.update(DISABLED_BACKENDS_CONFIG)
# NB: Set `--concurrent` so that if this script is running under `pantsd`, the validation
# won't kill it.
subprocess.run([dest, "--concurrent", "--version"], env=env, check=True)
green(f"Validated {dest}")


# -----------------------------------------------------------------------------------------------
# Fetch and stabilize the versions of wheels for publishing
Expand Down Expand Up @@ -946,9 +934,6 @@ def upload_wheels_via_twine() -> None:
[
str(CONSTANTS.twine_venv_dir / "bin/twine"),
"upload",
"--sign",
f"--sign-with={get_pgp_program_name()}",
f"--identity={get_pgp_key_id()}",
"--skip-existing", # Makes the upload idempotent.
str(CONSTANTS.deploy_pants_wheel_dir / CONSTANTS.pants_stable_version / "*.whl"),
],
Expand Down