-
-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python_distribution editable installs in exports #18639
Merged
Merged
Commits on Apr 8, 2023
-
Configuration menu - View commit details
-
Copy full SHA for d1cfd68 - Browse repository at this point
Copy the full SHA d1cfd68View commit details -
Configuration menu - View commit details
-
Copy full SHA for d36b839 - Browse repository at this point
Copy the full SHA d36b839View commit details -
Configuration menu - View commit details
-
Copy full SHA for 49465d9 - Browse repository at this point
Copy the full SHA 49465d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 692afac - Browse repository at this point
Copy the full SHA 692afacView commit details -
Configuration menu - View commit details
-
Copy full SHA for eb941f4 - Browse repository at this point
Copy the full SHA eb941f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for d15ecb4 - Browse repository at this point
Copy the full SHA d15ecb4View commit details -
Configuration menu - View commit details
-
Copy full SHA for b18f000 - Browse repository at this point
Copy the full SHA b18f000View commit details -
Configuration menu - View commit details
-
Copy full SHA for cfd7213 - Browse repository at this point
Copy the full SHA cfd7213View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7a52ce0 - Browse repository at this point
Copy the full SHA 7a52ce0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6909550 - Browse repository at this point
Copy the full SHA 6909550View commit details -
Configuration menu - View commit details
-
Copy full SHA for d86a9a7 - Browse repository at this point
Copy the full SHA d86a9a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for cec0583 - Browse repository at this point
Copy the full SHA cec0583View commit details -
Configuration menu - View commit details
-
Copy full SHA for 750c562 - Browse repository at this point
Copy the full SHA 750c562View commit details -
refactor editable wheel passing and installation
Installing the editable wheels via a pex was not effective. Using pex-tools to install two different pexes in the same venv caused conflicts with the __main__.py file. Using pex_path did not work because the editable wheel pex only had the editable wheels, not any of the dependencies. So, installing them in a pex was not effective. However, it does work to tell pex that the wheels are "sources". That way, pex just dumps them in the lib directory. Then, it was just a matter of adding the post-processing commands to move, install, and wrap up installation of the editable wheels. Even though we use pip to install the editable wheels, pants is both backend and frontend for PEP 660, because we generate the wheel (delegating dist-info generation to the external backend) and then install the wheel (delegating unpacking the wheel to pip). The final piece of complying with PEP-660 is to mark the install as an editable install via direct_url.json. We generate that when building the wheel, and then move it into place after pip has installed the editable wheels for us. One other method I considered was installing the editable wheels in the requirements pex. But I could not figure out how to combine EntireLockfile with additional wheel requirements. So, I punted and went merely passing the wheels as is via pex instead of attempting to install them in any pex. Finally, all of the export and local_dists_pep660 test pass!
Configuration menu - View commit details
-
Copy full SHA for f2b8b58 - Browse repository at this point
Copy the full SHA f2b8b58View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3557fac - Browse repository at this point
Copy the full SHA 3557facView commit details -
add [export].py-editables-in-resolves option
This way people have to opt into including the editables (and therefore incurring the cost of finding/building/installing the PEP-660 wheels).
Configuration menu - View commit details
-
Copy full SHA for 6357b85 - Browse repository at this point
Copy the full SHA 6357b85View commit details -
Configuration menu - View commit details
-
Copy full SHA for b65a079 - Browse repository at this point
Copy the full SHA b65a079View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0aa9172 - Browse repository at this point
Copy the full SHA 0aa9172View commit details -
Configuration menu - View commit details
-
Copy full SHA for d5b3562 - Browse repository at this point
Copy the full SHA d5b3562View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2001e4f - Browse repository at this point
Copy the full SHA 2001e4fView commit details -
Configuration menu - View commit details
-
Copy full SHA for b660c57 - Browse repository at this point
Copy the full SHA b660c57View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f57983 - Browse repository at this point
Copy the full SHA 3f57983View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c1df00 - Browse repository at this point
Copy the full SHA 9c1df00View commit details -
Configuration menu - View commit details
-
Copy full SHA for 017dc7b - Browse repository at this point
Copy the full SHA 017dc7bView commit details -
Configuration menu - View commit details
-
Copy full SHA for d230ea5 - Browse repository at this point
Copy the full SHA d230ea5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d95146 - Browse repository at this point
Copy the full SHA 0d95146View commit details -
Configuration menu - View commit details
-
Copy full SHA for fb4fbcd - Browse repository at this point
Copy the full SHA fb4fbcdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 26d0091 - Browse repository at this point
Copy the full SHA 26d0091View commit details -
Configuration menu - View commit details
-
Copy full SHA for c50724e - Browse repository at this point
Copy the full SHA c50724eView commit details
Commits on Apr 9, 2023
-
Configuration menu - View commit details
-
Copy full SHA for e4f0748 - Browse repository at this point
Copy the full SHA e4f0748View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9090edf - Browse repository at this point
Copy the full SHA 9090edfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 15fbc1e - Browse repository at this point
Copy the full SHA 15fbc1eView commit details
Commits on Apr 10, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 8250103 - Browse repository at this point
Copy the full SHA 8250103View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.