Fix Poetry req synthesis for URLs with markers. #18535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the PEP-508 direct reference URL requirement synthesis ran afoul of creating ambiguous requirement strings as detailed here: pypa/packaging#456 (comment) Fixes pantsbuild#18530
jsirois
commented
Mar 21, 2023
| @@ -107,35 +107,43 @@ def test_handle_str(test, exp) -> None: | |||
| assert parse_str_version(test, proj_name="foo", file_path="", extras_str="") == f"foo {exp}" | |||
|
|
|||
|
|
|||
| def assert_equal_requirements(actual: str | None, expected: str) -> None: | |||
| assert actual is not None | |||
| assert PipRequirement.parse(expected) == PipRequirement.parse(actual) | |||
There was a problem hiding this comment.
This is the new test. Previously the tests were ~vacuous in that the outputs were not tested against reality, which is packaging in this case (which PipRequirement is our wrapper around).
stuhood
approved these changes
Mar 21, 2023
jsirois
added a commit
to jsirois/pants
that referenced
this pull request
Mar 21, 2023
…build#18535) Previously the PEP-508 direct reference URL requirement synthesis ran afoul of creating ambiguous requirement strings as detailed here: pypa/packaging#456 (comment) Fixes pantsbuild#18530 (cherry picked from commit 54fb80b)
jsirois
added a commit
to jsirois/pants
that referenced
this pull request
Mar 21, 2023
…build#18535) Previously the PEP-508 direct reference URL requirement synthesis ran afoul of creating ambiguous requirement strings as detailed here: pypa/packaging#456 (comment) Fixes pantsbuild#18530 (cherry picked from commit 54fb80b)
jsirois
added a commit
to jsirois/pants
that referenced
this pull request
Mar 21, 2023
…build#18535) Previously the PEP-508 direct reference URL requirement synthesis ran afoul of creating ambiguous requirement strings as detailed here: pypa/packaging#456 (comment) Fixes pantsbuild#18530 (cherry picked from commit 54fb80b) [ci skip-rust] [ci skip-build-wheels]
jsirois
added a commit
that referenced
this pull request
Mar 21, 2023
… (#18536) Previously the PEP-508 direct reference URL requirement synthesis ran afoul of creating ambiguous requirement strings as detailed here: pypa/packaging#456 (comment) Fixes #18530 (cherry picked from commit 54fb80b)
jsirois
added a commit
that referenced
this pull request
Mar 21, 2023
… (#18537) Previously the PEP-508 direct reference URL requirement synthesis ran afoul of creating ambiguous requirement strings as detailed here: pypa/packaging#456 (comment) Fixes #18530 (cherry picked from commit 54fb80b)
jsirois
added a commit
that referenced
this pull request
Mar 21, 2023
… (#18538) Previously the PEP-508 direct reference URL requirement synthesis ran afoul of creating ambiguous requirement strings as detailed here: pypa/packaging#456 (comment) Fixes #18530 (cherry picked from commit 54fb80b) [ci skip-rust] [ci skip-build-wheels]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the PEP-508 direct reference URL requirement synthesis ran
afoul of creating ambiguous requirement strings as detailed here:
pypa/packaging#456 (comment)
Fixes #18530