-
-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor plumbing for test
goal to support batched tests.
#17044
Refactor plumbing for test
goal to support batched tests.
#17044
Commits on Sep 28, 2022
-
Refactor plumbing for
test
goal to support batched tests.The new structure is heavily inspired by recent work to refactor the way `lint` and `fmt` batch inputs. I don't expect any behavior change from this diff - all plugins providing a `test` implementation are coded to return single-element partitions. Once the plumbing has merged to `main` I plan to follow-up with an implementation of `pytest` batching. Known TODOs: - Restore the warning/error raised if no applicable targets are found for the input specs - Restore use of environments in this flow [ci skip-rust] [ci skip-build-wheels]
Configuration menu - View commit details
-
Copy full SHA for bb641b8 - Browse repository at this point
Copy the full SHA bb641b8View commit details -
I deleted a handful of tests when I was getting started because I thought they would no longer be relevant. Turns out they continue to work with a few tweaks, so we can restore them to avoid losing coverage. [ci skip-rust] [ci skip-build-wheels]
Configuration menu - View commit details
-
Copy full SHA for 779089a - Browse repository at this point
Copy the full SHA 779089aView commit details -
[ci skip-rust] [ci skip-build-wheels]
Configuration menu - View commit details
-
Copy full SHA for d86caa5 - Browse repository at this point
Copy the full SHA d86caa5View commit details -
Remove
tester_name
field fromTestResult
.Tracking the name of the test tool didn't really give us much - delete it, and simplify the code that used to use it. [ci skip-rust] [ci skip-build-wheels]
Configuration menu - View commit details
-
Copy full SHA for 3f9e68d - Browse repository at this point
Copy the full SHA 3f9e68dView commit details -
Configuration menu - View commit details
-
Copy full SHA for b8344d0 - Browse repository at this point
Copy the full SHA b8344d0View commit details
Commits on Sep 29, 2022
-
Delete
batch_size
option from[test]
subsystem.Hard-code a value of 1 for now where it was being used. [ci skip-rust] [ci skip-build-wheels]
Configuration menu - View commit details
-
Copy full SHA for 9332ec4 - Browse repository at this point
Copy the full SHA 9332ec4View commit details -
Restore environment-awareness to
test
goal.Look up the environment name for each element in a test partition, and assert that everything in a partition matches. [ci skip-rust] [ci skip-build-wheels]
Configuration menu - View commit details
-
Copy full SHA for 8e08a21 - Browse repository at this point
Copy the full SHA 8e08a21View commit details -
Restore logic to warn/error if
test
is run on a non-applicable target.[ci skip-rust] [ci skip-build-wheels]
Configuration menu - View commit details
-
Copy full SHA for 6562137 - Browse repository at this point
Copy the full SHA 6562137View commit details -
Add field for prefix of extra test output.
[ci skip-rust] [ci skip-build-wheels]
Configuration menu - View commit details
-
Copy full SHA for 68eb776 - Browse repository at this point
Copy the full SHA 68eb776View commit details
Commits on Sep 30, 2022
-
Configuration menu - View commit details
-
Copy full SHA for ef75935 - Browse repository at this point
Copy the full SHA ef75935View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2032440 - Browse repository at this point
Copy the full SHA 2032440View commit details -
raise AssertionError
s instead ofassert
ing.[ci skip-rust] [ci skip-build-wheels]
Configuration menu - View commit details
-
Copy full SHA for 85afb9b - Browse repository at this point
Copy the full SHA 85afb9bView commit details -
Clean up comments and unused property
[ci skip-rust] [ci skip-build-wheels]
Configuration menu - View commit details
-
Copy full SHA for a4d1d77 - Browse repository at this point
Copy the full SHA a4d1d77View commit details -
Merge branch 'main' into danxmoran/batched-test-plumbing
[ci skip-rust] [ci skip-build-wheels]
Configuration menu - View commit details
-
Copy full SHA for 7d7833a - Browse repository at this point
Copy the full SHA 7d7833aView commit details -
Rename
description
->partition_description
[ci skip-rust] [ci skip-build-wheels]
Configuration menu - View commit details
-
Copy full SHA for 479fe6a - Browse repository at this point
Copy the full SHA 479fe6aView commit details
Commits on Oct 3, 2022
-
Merge branch 'main' into danxmoran/batched-test-plumbing
[ci skip-build-wheels]
Configuration menu - View commit details
-
Copy full SHA for 2718f49 - Browse repository at this point
Copy the full SHA 2718f49View commit details -
Rename
elements
tofield_sets
inTestRequest.SubPartition
[ci skip-build-wheels]
Configuration menu - View commit details
-
Copy full SHA for 98b5711 - Browse repository at this point
Copy the full SHA 98b5711View commit details -
Add a separate field for `extra_output_prefix` for clarity [ci skip-rust] [ci skip-build-wheels]
Configuration menu - View commit details
-
Copy full SHA for 91b8b06 - Browse repository at this point
Copy the full SHA 91b8b06View commit details -
Merge branch 'main' into danxmoran/batched-test-plumbing
[ci skip-rust] [ci skip-build-wheels]
Configuration menu - View commit details
-
Copy full SHA for fb1fc15 - Browse repository at this point
Copy the full SHA fb1fc15View commit details
Commits on Oct 4, 2022
-
Stop passing around
extra_output_prefix
.This is currently only used by `pytest`, and we have a couple other fields with the same problem (de-duplicating between test runs) that we currently expect plugin implementers to handle. Incidentally, deleting the field flushed out some invalid `SubPartition`s built in tests that snuck through the previous cleanup commit. [ci skip-rust] [ci skip-build-wheels]
Configuration menu - View commit details
-
Copy full SHA for 7c6da21 - Browse repository at this point
Copy the full SHA 7c6da21View commit details