Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jvm: Add invalidation headers to lockfiles #13373

Closed
chrisjrn opened this issue Oct 27, 2021 · 1 comment · Fixed by #14185
Closed

jvm: Add invalidation headers to lockfiles #13373

chrisjrn opened this issue Oct 27, 2021 · 1 comment · Fixed by #14185
Assignees
@chrisjrn

Comments

@chrisjrn
Copy link
Contributor

JVM lockfiles should have invalidation headers similar to Python's, which will detect when the input requirements for a given coursier resolve stop being compatible with the lockfile.
@chrisjrn chrisjrn mentioned this issue Oct 27, 2021
Closed
@chrisjrn
Copy link
Contributor Author

chrisjrn commented Jan 7, 2022

Going to start with some pre-work to re-use dictionary versioning code that proved to be useful for Python support. (@cc @Eric-Arellano)

In terms of invalidation headers, I suspect the starting point for this is going to be JVM version constraints (however we represent those right now), along with maven coordinate strings for requirements.

@chrisjrn chrisjrn mentioned this issue Jan 7, 2022
Merged
chrisjrn pushed a commit that referenced this issue Jan 12, 2022
Factors lockfile metadata code into class that supports multiple lang…
dd454a6 
…uages as well as versions (#14116)

This is in aid of #13373. This factors out the LockfileMetadata base class into a language-agnostic form, which will allow changes to the JVM lockfile format in a future PR.

As far as I can tell, the existing lockfile metadata tests adequately cover this new refactoring for now.
@chrisjrn chrisjrn mentioned this issue Jan 14, 2022
Merged
chrisjrn pushed a commit that referenced this issue Jan 18, 2022
[internal] Change JVM lockfile format (#14175)
3799314 
Changes the serialization format from JSON to TOML, and updates all the relevant lockfiles.

Done as pre-work for #13373.
@chrisjrn chrisjrn mentioned this issue Jan 19, 2022
Merged
chrisjrn pushed a commit that referenced this issue Jan 19, 2022
JVM lockfile invalidation headers and verification (#14185)
e771911 
This adds support for JVM lockfile invalidation headers. Most of the infrastructure is shared with the equivalent Python support code.

Closes #13373
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisjrn chrisjrn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

JVM lockfile invalidation headers and verification chrisjrn/pants
1 participant
@chrisjrn