Skip to content

Commit

Permalink
Include extra_build_args on pex_binaries too (#20929)
Browse files Browse the repository at this point in the history
This moves the `extra_build_args` from being a field on `pex_binary`
only to being a common field, so it appears on both `pex_binary` and the
`pex_binaries` target generator.

I'd missed this in #20737.
  • Loading branch information
huonw committed May 15, 2024
1 parent 1c1ae0d commit 8ba6ea2
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions docs/notes/2.22.x.md
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,8 @@ Initial support for Python 3.13 (pre-release) has been added. NB. built-in tool

The [PyOxizider tool is effectively stagnant](https://github.com/indygreg/PyOxidizer/issues/7410). [The `pants.backend.experimental.python.packaging.pyoxidizer` backend](https://www.pantsbuild.org/2.22/docs/python/integrations/pyoxidizer) docs now have a note reflecting this.

[The `extra_build_args` field](https://www.pantsbuild.org/2.22/reference/targets/pex_binaries#extra_build_args) is now available on the `pex_binaries` target generator, in addition to `pex_binary`.

Default module mappings were added for more modules:

The deprecation for the `platforms` field for the `pex_binary` and `pex_binaries` targets has expired, and so has been removed. The `resolve_local_platforms` field is now meaningless and is thus deprecated.
Expand Down
2 changes: 1 addition & 1 deletion src/python/pants/backend/python/target_types.py
Original file line number Diff line number Diff line change
Expand Up @@ -755,6 +755,7 @@ class PexVenvHermeticScripts(BoolField):
PexIncludeToolsField,
PexVenvSitePackagesCopies,
PexVenvHermeticScripts,
PexExtraBuildArgsField,
RestartableField,
)

Expand All @@ -768,7 +769,6 @@ class PexBinary(Target):
PexScriptField,
PexExecutableField,
PexArgsField,
PexExtraBuildArgsField,
PexEnvField,
OutputPathField,
)
Expand Down

0 comments on commit 8ba6ea2

Please sign in to comment.