Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure the plugin can be translated using translate.wordpress.org #230

Merged
merged 2 commits into from
Feb 3, 2021
Merged

Make sure the plugin can be translated using translate.wordpress.org #230

merged 2 commits into from
Feb 3, 2021

Conversation

imath
Copy link
Contributor

@imath imath commented Feb 3, 2021

Hi,

Thanks a lot for your work on this very useful plugin. I wanted to contribute to the fr_FR translation from https://translate.wordpress.org/projects/wp-plugins/wp-saml-auth/ unfortunately it looks like the plugin needs to use the load_plugin_textdomain() function to make this possible (I've checked the log into the slack channel described below).

glotpress-issue

So I'm suggesting to do so into this PR and as I've found there was already some po/mo files for the french locale, I've updated them to latest version of the plugin.

@danielbachhuber danielbachhuber added this to the 1.1.1 milestone Feb 3, 2021
@danielbachhuber danielbachhuber merged commit 1acffac into pantheon-systems:master Feb 3, 2021
@danielbachhuber
Copy link
Contributor

Thanks @imath! I'll tag v1.1.1 in a moment.

@imath imath deleted the fix/load-textdomain branch February 3, 2021 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants