Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Robo 2.x #1918

Closed
wants to merge 2 commits into from
Closed

[WIP] Robo 2.x #1918

wants to merge 2 commits into from

Conversation

greg-1-anderson
Copy link
Member

I just released Robo version 1.3.5, which made some improvements to the way dependency injection works that will be important for Robo 2. For now, everything should also continue to work in the original way without any breakage.

Creating a PR to test if that is true here in practice.

@greg-1-anderson
Copy link
Member Author

Well, that didn't work at all. I've reverted the breaking changes in Robo 1.x, and moved them into Robo 2.x development. I'll continue with this PR to see about getting Terminus working with Robo 2, but no pressure to upgrade. Robo 2 will drop support for PHP 5.x; see consolidation/robo#548 for other details.

TeslaDethray
TeslaDethray previously approved these changes Jan 8, 2019
@greg-1-anderson greg-1-anderson changed the title Robo 1.3.5 [WIP] Robo 2.x Jan 8, 2019
@greg-1-anderson
Copy link
Member Author

greg-1-anderson commented Jan 8, 2019

I couldn't get the changes I made in Robo 1.3.5 to work right and still be backwards compatible, so I backed them out in Robo 1.4.0, and moved this work to the Robo 2.x branch. I'll continue to use this PR as a work place to ensure that Terminus remains compatible with Robo 2. We shouldn't merge here until:

  • There is a stable release of Robo 2
  • Terminus is ready to drop support for PHP 5.6 and earlier, perhaps PHP 7.0 as well (e

Exact supported PHP versions in Robo 2 not decided yet, but 7.0 is EOL. Motivation for dropping 7.0 would be to allow Robo to eventually require dependencies that don't support it, e.g. Symfony 4 -- but it's unclear at this point whether that will be necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants