Update the new merges#5
Merged
Merged
Conversation
…provements (#600) This is another round of improvements for the pythonized WE2E test scripts. I was originally going to wait until the script was ready to replace, but I accidentally forgot to make a change to a final log message in monitor_jobs.py; this results in a scary-looking error message even though all experiments may have completed successfully. The solution was simply to replace the undefined variable with a correct one. This PR comes from an in-progress branch for improvements to the python scripts, so a few other improvements are coming along with this bug fix: * When monitor_jobs.py is called for the first time, it will check the status of all jobs, not just those that are incomplete. This will allow users to use this script to monitor a previously failed job that has been fixed. * Add checks for proper run_envir, and add all needed variables for run_envir=nco mode. * Fix another incorrect error message in setup.py.
Currently if you grep for unbound variables in your experiement directories log files, you will find many BASH_SOURCE: unbound variables messages, which may cause confusion when one is debugging a problem. The culprit files are filesys_cmds_vrfy.sh, print_msg.sh, change_cases.sh and preamble.sh. This PR fixes these files, so there should not be any unbound variables in the log files now. Additionally, updated .cicd/Jenkinsfile to keep tests from running on Hera (which is currently down in the Jenkins CI pipeline. --------- Co-authored-by: Michael Lueken <michael.lueken@noaa.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update develop to head at ufs-community
Use this template to give a detailed message describing the change you want to make to the code.
You may delete any sections labeled "optional" and any instructions within .
If you are unclear on what should be written here, see https://github.com/wrf-model/WRF/wiki/Making-a-good-pull-request-message for some guidance and review the Code Contributor's Guide at https://github.com/ufs-community/ufs-srweather-app/wiki/Code-Manager's-Guide.
Code reviewers will assess the PR based on the criteria laid out in the Code Reviewer's Guide (https://github.com/ufs-community/ufs-srweather-app/wiki/Code-Manager's-Guide).
The title of this pull request should be a brief summary (ideally less than 100 characters) of the changes included in this PR. Please also include the branch to which this PR is being issued (e.g., "[develop]: Updated UFS_UTILS hash").
Use the "Preview" tab to see what your PR will look like when you hit "Create pull request"
--- Delete this line and those above before hitting "Create pull request" ---
DESCRIPTION OF CHANGES:
Type of change
TESTS CONDUCTED:
DEPENDENCIES:
DOCUMENTATION:
ISSUE:
CHECKLIST
LABELS (optional):
A Code Manager needs to add the following labels to this PR:
CONTRIBUTORS (optional):