Nests CombineReference inside of WriteCombineReference Transform
#635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cisaacstern
reviewed
Sep 28, 2023
cisaacstern
reviewed
Sep 28, 2023
cisaacstern
reviewed
Sep 28, 2023
cisaacstern
reviewed
Sep 28, 2023
cisaacstern
reviewed
Sep 28, 2023
There was a problem hiding this comment.
Thanks for the lighting fast ⚡ pickup on this one, @norlandrhagen!
Looking good, a few comments below re: required args.
Also, before merging could you make this change to the two kerchunk recipes in https://github.com/pangeo-forge/pangeo-forge-recipes/tree/main/examples/feedstock as well?
Thanks so much!
|
Thanks for the review @cisaacstern. Pretty sure all of the feedback is addressed! |
cisaacstern
added
the
test-integration
|
Thanks so much @norlandrhagen ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for issue: #634
cc @cisaacstern