Close frontend review findings - #141
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e99f4b79c2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| comment.path === finding.path && | ||
| (finding.sourceId | ||
| ? comment.sourceFindingId === finding.sourceId | ||
| : comment.body === generatedBody), |
There was a problem hiding this comment.
Keep recognizing drafted report-only findings
When finding.sourceId is truthy, this branch stops considering the generated body, but readPrReviewRow() now synthesizes sourceId for older report_only_findings_json rows whose existing draft comments still have source_finding_id null. After upgrading, even an already-generated legacy comment is treated as not drafted (and cross-file manual anchors also miss because of the path guard), so the sidebar re-enables “choose line” and can create duplicate draft comments for the same finding.
Useful? React with 👍 / 👎.
Summary
Why
This is the closing implementation pass for the frontend static review. The remaining issues could cause visual jitter, stale or misleading operation feedback, timer races, incorrect finding identity, and configuration that did not match the exposed agent and session routes.
Impact
The PR review workbench now keeps feedback scoped to the latest operation and tracks generated findings independently of editable display text. Shared live metrics render steadily, navigation pulses clean up correctly, and unsupported Flue agent names fail safely with a visible configuration issue.
Validation