Measure real PR review performance - #137
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c814f1ca48
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| !state.threadsVisibleMs && | ||
| body.includes(`/${expectedThreadCount}`) && | ||
| body.includes('threads') |
There was a problem hiding this comment.
Require loaded thread state before timing zero-thread PRs
If this benchmark is run against a PR with no review threads, the review header already renders 0/0 threads before the review-threads request resolves, so body.includes('/0') && body.includes('threads') can mark threadsVisibleMs at initial paint instead of endpoint/UI readiness. That makes zero-thread PR samples under-report the thread path the harness claims to measure; wait for a completed thread response or a loaded-state marker before accepting the 0 case.
Useful? React with 👍 / 👎.
Summary
npm run bench:pr-reviewcommand for immutable revisions in registered repositoriesReal target
Measured open
Kilo-Org/kilocode#12204at a fixed head/base revision:Results
Discussion gate
This PR intentionally does not implement the measured production fixes. The plan now proposes, in order:
Verification
npm run bench:pr-review -- ... --samples 3npm run build:dashboardnpm run check(84 files, 524 tests)npm run format:checkgit diff --check