TST: Add regression test for groupby.var/std arrow dtype retention - #64093
Closed
immohamedadhil wants to merge 6 commits into
Closed
TST: Add regression test for groupby.var/std arrow dtype retention#64093immohamedadhil wants to merge 6 commits into
immohamedadhil wants to merge 6 commits into
Conversation
3 tasks
Contributor
|
I already have a PR open since 16th January to close #54627 so |
1 task
Member
|
closed by #63704 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation:
Test that
int64[pyarrow]inputs correctly returnfloat64[pyarrow]instead of falling back to NumPyfloat64.Added the following tests to
pandas/tests/extension/test_arrow.py:test_groupby_var_returns_arrow_dtype: Verifiesint64->float64[pyarrow](Fixes GH#54627).test_groupby_std_returns_arrow_dtype: Same for std.Both tests follow the existing pattern in
test_arrow.py