TYP: misc return types #57285
Merged
TYP: misc return types #57285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twoertwein
commented
Feb 7, 2024
| indexer: npt.NDArray[np.intp], | ||
| new_index: Index, | ||
| ) -> NDFrameT: | ||
| ) -> DataFrame | Series: |
Member
Author
There was a problem hiding this comment.
Had to switch to the overloads as Series._constructor returns type[Series] and not type[Self]
twoertwein
requested review from
Dr-Irv,
MarcoGorelli and
rhshadrach
as code owners
mroeschke
approved these changes
Feb 7, 2024
Member
|
Thanks @twoertwein |
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.