Skip to content

Conversation

@phofl
Copy link
Member

@phofl phofl commented Feb 4, 2024

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

xref #53710

@phofl phofl added this to the 3.0 milestone Feb 4, 2024
@rhshadrach rhshadrach added Deprecate Functionality to remove in pandas DataFrame DataFrame data structure labels Feb 4, 2024
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rhshadrach rhshadrach merged commit 36d454a into pandas-dev:main Feb 4, 2024
@rhshadrach
Copy link
Member

Thanks @phofl

@phofl phofl deleted the first_last branch February 4, 2024 15:17
@phofl
Copy link
Member Author

phofl commented Feb 4, 2024

@rhshadrach you can’t add the deprecation label, otherwise the bot will pick it up

we would have to add a new label if we want to group the enforcals somehow

@rhshadrach
Copy link
Member

Ah - thanks

pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DataFrame DataFrame data structure Deprecate Functionality to remove in pandas

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants