Skip to content

Conversation

@Will-So
Copy link
Contributor

@Will-So Will-So commented Jan 22, 2024

ambiguous takes bool as an argument, not bool-ndarray. [True, False] wouldn't make sense in this context.

Docstring update so checklist N/A.

ambiguous takes bool as an argument, not bool-ndarray
@mroeschke mroeschke added Docs Timezones Timezone data dtype labels Jan 22, 2024
datapythonista and others added 2 commits January 29, 2024 11:49
Co-authored-by: Matthew Roeschke <[email protected]>
Co-authored-by: Matthew Roeschke <[email protected]>
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged @mroeschke proposal, so this can be merged. Looks good to me too now.

@mroeschke mroeschke added this to the 3.0 milestone Jan 29, 2024
@mroeschke
Copy link
Member

Thanks @Will-So @datapythonista

@mroeschke mroeschke merged commit dc5586b into pandas-dev:main Jan 29, 2024
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
…ev#57015)

* ambiguous takes bool as an argument, not bool-ndarray

ambiguous takes bool as an argument, not bool-ndarray

* Update pandas/core/generic.py

Co-authored-by: Matthew Roeschke <[email protected]>

* Update pandas/core/generic.py

Co-authored-by: Matthew Roeschke <[email protected]>

---------

Co-authored-by: Marc Garcia <[email protected]>
Co-authored-by: Matthew Roeschke <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Docs Timezones Timezone data dtype

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants