Skip to content

DEPR: groupby.fillna #55719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 16, 2023
Merged

DEPR: groupby.fillna #55719

merged 8 commits into from
Nov 16, 2023
+190 −79

Conversation

rhshadrach
Copy link
Member

@rhshadrach rhshadrach commented Oct 27, 2023 •
edited
Loading

@rhshadrach rhshadrach added Groupby Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Deprecate Functionality to remove in pandas Transformations e.g. cumsum, diff, rank labels Oct 27, 2023
@rhshadrach rhshadrach added this to the 2.2 milestone Oct 27, 2023
@rhshadrach rhshadrach marked this pull request as draft October 31, 2023 21:12
@rhshadrach rhshadrach marked this pull request as ready for review November 14, 2023 22:26
mroeschke
mroeschke reviewed Nov 15, 2023
View reviewed changes
mroeschke
mroeschke reviewed Nov 15, 2023
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment otherwise looks good

mroeschke
mroeschke reviewed Nov 16, 2023
View reviewed changes
@mroeschke mroeschke merged commit 5457e59 into pandas-dev:main Nov 16, 2023
@mroeschke
Copy link
Member

Thanks @rhshadrach

@github-actions github-actions bot mentioned this pull request Nov 16, 2023
Closed
@rhshadrach rhshadrach deleted the depr_groupby_fillna branch November 16, 2023 21:50
@mroeschke mroeschke mentioned this pull request Feb 7, 2024
Merged
3 tasks
rapids-bot bot pushed a commit to rapidsai/cudf that referenced this pull request Feb 8, 2024
@mroeschke
Deprecate groupby fillna (#15000)
7f28f2f 
Deprecated in pandas 2.2 pandas-dev/pandas#55719

Authors:
  - Matthew Roeschke (https://github.com/mroeschke)

Approvers:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

URL: #15000
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees

No one assigned

Labels

Deprecate Functionality to remove in pandas Groupby Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Transformations e.g. cumsum, diff, rank

Projects

None yet

Milestone

2.2

Development

Successfully merging this pull request may close these issues.

DEPR: groupby.fillna DEPR: inplace in DataFrameGroupBy.fillna and SeriesGroupBy.fillna DEPR: GroupBy.fillna positional arguments

2 participants

@rhshadrach @mroeschke