Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC move resample bug whatsnew notes to 2.2 #55309

Merged
merged 4 commits into from
Oct 6, 2023

Conversation

MarcoGorelli
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@MarcoGorelli MarcoGorelli marked this pull request as ready for review September 27, 2023 20:32
@MarcoGorelli MarcoGorelli added this to the 2.2 milestone Sep 27, 2023
@@ -251,6 +251,10 @@ Bug fixes
- Bug in :class:`pandas.core.window.Rolling` where duplicate datetimelike indexes are treated as consecutive rather than equal with ``closed='left'`` and ``closed='neither'`` (:issue:`20712`)
- Bug in :meth:`DataFrame.apply` where passing ``raw=True`` ignored ``args`` passed to the applied function (:issue:`55009`)
- Bug in :meth:`pandas.read_excel` with a ODS file without cached formatted cell for float values (:issue:`55219`)
- Fixed bug in :meth:`DataFrame.resample` not respecting ``closed`` and ``label`` arguments for :class:`~pandas.tseries.offsets.BusinessDay` (:issue:`55282`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move this to the Groupby/resample/rolling section? (These other ones need to be moved at some point too)

@phofl
Copy link
Member

phofl commented Oct 5, 2023

Thx!

@mroeschke mroeschke merged commit e4635ac into pandas-dev:main Oct 6, 2023
@mroeschke
Copy link
Member

Thanks @MarcoGorelli (do the changes to 2.1.2.rst need to be backported then?)

@MarcoGorelli
Copy link
Member Author

i hadn't backported it to begin with so I don't think so

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants