ENH: allow opt-in to inferring pyarrow strings #54342
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
reviewed
Aug 1, 2023
Member
phofl
left a comment
phofl
left a comment
There was a problem hiding this comment.
I wouldn't add the warning for 2.1 (this is also consistent with the pdep), simply adding an option to convert should be good for now.
Member
Author
|
I'm not as invested as you in getting this in for 2.1. Want to take over this PR? |
mroeschke
added
Strings
Member
|
I have some trouble pushing to other forks, opened #54430 with tests and removed the comments |
Member
Author
|
Closing in favor of #54430 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @phofl
Enabling this at the top of conftest.py breaks 4290 tests.