Skip to content

PERF: ArrowDtype.__eq__ #54223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 25, 2023
Merged

PERF: ArrowDtype.__eq__ #54223

merged 2 commits into from
Jul 25, 2023

Conversation

@lukemanley
Copy link
Member

@lukemanley lukemanley commented Jul 22, 2023

Micro-perf improvement:

import pandas as pd
import pyarrow as pa

a = pd.ArrowDtype(pa.float64())
b = pd.ArrowDtype(pa.float64())

%timeit a == b

# 2.86 µs ± 214 ns per loop (mean ± std. dev. of 7 runs, 100,000 loops each)   -> main
# 473 ns ± 15.2 ns per loop (mean ± std. dev. of 7 runs, 1,000,000 loops each) -> PR

@lukemanley lukemanley added Performance Memory or execution speed performance Arrow pyarrow functionality labels Jul 22, 2023
@lukemanley lukemanley added this to the 2.1 milestone Jul 22, 2023
mroeschke
mroeschke reviewed Jul 24, 2023
View reviewed changes
@mroeschke mroeschke merged commit 23a1767 into pandas-dev:main Jul 25, 2023
@mroeschke
Copy link
Member

mroeschke commented Jul 25, 2023

Thanks @lukemanley

@lukemanley lukemanley deleted the perf-arrowdtype-eq branch July 25, 2023 00:15
jamie-harness pushed a commit to jamie-harness/pandas1 that referenced this pull request Jul 25, 2023
@lukemanley @jamie-harness
PERF: ArrowDtype.__eq__ (pandas-dev#54223)
ec20e4e 
* PERF: ArrowDtype.__eq__

* cleanup
jamie-harness added a commit to jamie-harness/pandas1 that referenced this pull request Jul 25, 2023
@jamie-harness @lukemanley
PERF: ArrowDtype.__eq__ (pandas-dev#54223) (#15)
b2c6c86 
* PERF: ArrowDtype.__eq__

* cleanup

Co-authored-by: Luke Manley <[email protected]>
jamie-harness pushed a commit to jamie-harness/pandas1 that referenced this pull request Jul 26, 2023
@lukemanley @jamie-harness
PERF: ArrowDtype.__eq__ (pandas-dev#54223)
af73848 
* PERF: ArrowDtype.__eq__

* cleanup
jamie-harness added a commit to jamie-harness/pandas1 that referenced this pull request Jul 26, 2023
@jamie-harness @lukemanley
PERF: ArrowDtype.__eq__ (pandas-dev#54223) (#27)
340d162 
* PERF: ArrowDtype.__eq__

* cleanup

Co-authored-by: Luke Manley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees

No one assigned

Labels

Arrow pyarrow functionality Performance Memory or execution speed performance

Projects

None yet

Milestone

2.1

Development

Successfully merging this pull request may close these issues.

2 participants

@lukemanley @mroeschke