Skip to content

DEPR: Remove bytes input for read_excel #53830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 27, 2023
Merged

DEPR: Remove bytes input for read_excel #53830

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a171b99
Adding deprecation logic and updating documentation.
rmhowe425 Jun 24, 2023
17353ea
Adding PR number to new unit test
rmhowe425 Jun 24, 2023
5c5bdec
Updating read_excel() documentation per reviewer recommendations.
rmhowe425 Jun 25, 2023
17ff094
Updating read_excel() documentation per reviewer recommendations.
rmhowe425 Jun 25, 2023
a9ef371
Updating read_excel() documentation per reviewer recommendations.
rmhowe425 Jun 26, 2023
c92a3d6
Updating implementation per reviewer recommendations.
rmhowe425 Jun 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pandas/io/excel/_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,8 @@
or ``StringIO``.
.. deprecated:: 2.1.0
Passing byte strings is deprecated. To read from a "
"byte string, wrap it in a `BytesIO` object.
Passing byte strings is deprecated. To read from a
byte string, wrap it in a `BytesIO` object.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry - I missed this before. The API docs are autogenerated using sphinx. For sphinx, you need a double backtick here: ``BytesIO``.

sheet_name : str, int, list, or None, default 0
Strings are used for sheet names. Integers are used in zero-indexed
sheet positions (chart sheets do not count as a sheet position).
Expand Down