Skip to content

Conversation

@MarcoGorelli
Copy link
Member

@MarcoGorelli MarcoGorelli commented Jun 19, 2023

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

Tried to catch the warning within online_ewma but then I get

numba.core.errors.CompilerError: Failed in nopython mode pipeline (step: Handle with contexts)
Unsupported context manager in use

File "pandas/core/window/online.py", line 58:
    def online_ewma(
        <source elided>
        nobs = (~np.isnan(weighted_avg)).astype(np.int64)
        with warnings.catch_warnings():

@MarcoGorelli MarcoGorelli marked this pull request as ready for review June 19, 2023 15:33
@lithomas1
Copy link
Contributor

Yeah, nopython mode do be like that.

Apparently the warning is a numba bug to be fixed in 0.57.1
numba/numba#8936.

@lithomas1 lithomas1 added this to the 2.0.3 milestone Jun 19, 2023
@MarcoGorelli MarcoGorelli added Docs CI Continuous Integration labels Jun 19, 2023
@MarcoGorelli
Copy link
Member Author

thanks for the quick review

this fixes the docs build, so merging

@MarcoGorelli MarcoGorelli merged commit b69dccd into pandas-dev:main Jun 19, 2023
@lumberbot-app
Copy link

lumberbot-app bot commented Jun 19, 2023

Can't Dooooo.... It seem like this is already backported (commit is empty).I won't do anything. MrMeeseeks out.

@MarcoGorelli
Copy link
Member Author

Can't Dooooo.... It seem like this is already backported (commit is empty).I won't do anything. MrMeeseeks out.

u wot m8

@MarcoGorelli
Copy link
Member Author

ah looks like @mroeschke had already made the same fix, but on the 2.0.x branch https://github.com/pandas-dev/pandas/pull/53372/files

all good then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Continuous Integration Docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants