Skip to content

TST: fix import in test_hash_pandas_object extension test #53474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2023
Merged

TST: fix import in test_hash_pandas_object extension test #53474

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pandas/tests/extension/base/methods.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@ class BaseMethodsTests(BaseExtensionTests):
def test_hash_pandas_object(self, data):
# _hash_pandas_object should return a uint64 ndarray of the same length
# as the data
from pandas.core.util.hashing import _default_hash_key
Copy link
Member

@jbrockmendel jbrockmendel May 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC the issue is that hashing hasnt been imported into core.util. Should we try to address that directly?

Copy link
Member Author

@jorisvandenbossche jorisvandenbossche May 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really care either way; it's not a public import, and internally we always import it correctly instead of using it from a top-level pandas object.

Copy link
Member

@jbrockmendel jbrockmendel Jun 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really care either way

Agreed. I'm fine with this.


res = data._hash_pandas_object(
encoding="utf-8",
hash_key=pd.core.util.hashing._default_hash_key,
categorize=False,
encoding="utf-8", hash_key=_default_hash_key, categorize=False
)
assert res.dtype == np.uint64
assert res.shape == data.shape
Expand Down